fix(アイドルマスターシャイニーカラーズ): implement iframe support to fix presence not updating #10293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tatsuya087
commented
Dec 25, 2025
tatsuya087
commented
- add iframe.ts to capture hash-based routing updates
- update presence.ts to handle, filter and map iframe data
- enable iframe support in metadata.json
- update activity assets (logo and thumbnail)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
theusaf
approved these changes
Jan 3, 2026
Bas950
requested changes
Jan 3, 2026
| ] | ||
| ], | ||
| "iframe": true, | ||
| "iFrameRegExp": ".*" |
Member
There was a problem hiding this comment.
Add an actual regexp instead of catching all
auto-merge was automatically disabled
January 4, 2026 00:15
Head branch was pushed to by a user without write access
Member
|
0 files changed? |
Contributor
Author
|
wtf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.