Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
193 changes: 193 additions & 0 deletions src/javascript-web/javascript-web-wizard-agent.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,193 @@
/* Generic JavaScript Web (client-side) wizard using posthog-agent with PostHog MCP */
import type { WizardOptions } from '../utils/types';
import type { FrameworkConfig } from '../lib/framework-config';
import { Integration } from '../lib/constants';
import * as fs from 'node:fs';
import * as path from 'node:path';
import { hasPackageInstalled } from '../utils/package-json';
import { tryGetPackageJson } from '../utils/clack-utils';
import {
FRAMEWORK_PACKAGES,
detectJsPackageManager,
detectBundler,
type JavaScriptContext,
} from './utils';

export const JAVASCRIPT_WEB_AGENT_CONFIG: FrameworkConfig<JavaScriptContext> = {
metadata: {
name: 'JavaScript (Web)',
integration: Integration.javascript_web,
beta: true,
docsUrl: 'https://posthog.com/docs/libraries/js',
gatherContext: (options: WizardOptions) => {
const packageManagerName = detectJsPackageManager(options);
const hasTypeScript = fs.existsSync(
path.join(options.installDir, 'tsconfig.json'),
);
const hasBundler = detectBundler(options);
return Promise.resolve({ packageManagerName, hasTypeScript, hasBundler });
},
},

detection: {
packageName: 'posthog-js',
packageDisplayName: 'JavaScript (Web)',
usesPackageJson: false,
getVersion: () => undefined,
detect: async (options) => {
const packageJson = await tryGetPackageJson(options);
if (!packageJson) {
return false;
}

// Exclude projects with known framework packages
for (const frameworkPkg of FRAMEWORK_PACKAGES) {
if (hasPackageInstalled(frameworkPkg, packageJson)) {
return false;
}
}

// Ensure this is actually a JS project, not just a package.json for tooling
const { installDir } = options;

// Check for a lockfile
const hasLockfile = [
'package-lock.json',
'yarn.lock',
'pnpm-lock.yaml',
'bun.lockb',
'bun.lock',
].some((lockfile) => fs.existsSync(path.join(installDir, lockfile)));

if (hasLockfile) {
return true;
}

// Fallback: check if package.json has actual dependencies
const hasDeps =
(packageJson.dependencies &&
Object.keys(packageJson.dependencies).length > 0) ||
(packageJson.devDependencies &&
Object.keys(packageJson.devDependencies).length > 0);

return !!hasDeps;
},
},

environment: {
uploadToHosting: false,
getEnvVars: (apiKey: string, host: string) => ({
POSTHOG_API_KEY: apiKey,
POSTHOG_HOST: host,
}),
},

analytics: {
getTags: (context) => {
const tags: Record<string, string> = {
packageManager: context.packageManagerName ?? 'unknown',
};
if (context.hasBundler) {
tags.bundler = context.hasBundler;
}
return tags;
},
},

prompts: {
projectTypeDetection:
'This is a JavaScript/TypeScript project. Look for package.json and lockfiles (package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb) to confirm.',
packageInstallation:
'Look for lockfiles to determine the package manager (npm, yarn, pnpm, bun). Do not manually edit package.json.',
getAdditionalContextLines: (context) => {
const lines = [
`Package manager: ${context.packageManagerName ?? 'unknown'}`,
`Has TypeScript: ${context.hasTypeScript ? 'yes' : 'no'}`,
`Framework docs ID: js (use posthog://docs/frameworks/js for documentation if available)`,
`Project type: Generic JavaScript/TypeScript application (no specific framework detected)`,
``,
`## CRITICAL: posthog-js Best Practices`,
``,
`### 1. Use posthog-js (Browser SDK)`,
`This is a client-side web JavaScript project. Use the posthog-js package, NOT posthog-node.`,
`posthog-js is designed for browser use and includes autocapture, session recording, and feature flags.`,
``,
`### 2. Initialization (REQUIRED)`,
`posthog.init() MUST be called before any other PostHog methods:`,
``,
`import posthog from 'posthog-js'`,
``,
`posthog.init('<api_key>', {`,
` api_host: '<host>',`,
`})`,
``,
`### 3. Autocapture`,
`Autocapture is ON by default with posthog-js. It tracks clicks, form submissions, and pageviews automatically.`,
`Do NOT disable autocapture unless the user explicitly requests it.`,
``,
`### 4. Error Tracking`,
`Use posthog.captureException(error) for error tracking.`,
``,
`### 5. NEVER Send PII in Event Properties`,
`DO NOT include in posthog.capture() event properties:`,
`- Email addresses, full names, phone numbers, physical addresses, IP addresses`,
`- Any user-generated content (messages, comments, form submissions)`,
``,
`SAFE event properties:`,
`posthog.capture('form_submitted', { form_type: 'contact', field_count: 5 })`,
``,
`UNSAFE (DO NOT DO THIS):`,
`posthog.capture('form_submitted', { email: userEmail, message: content })`,
``,
`### 6. User Identification (identify with person properties)`,
`Call posthog.identify() on login AND on page refresh if the user is already logged in.`,
`ALWAYS pass person properties as the second argument — this is where email/name/role BELONG:`,
``,
`posthog.identify(user.id, {`,
` email: user.email,`,
` name: user.name,`,
` role: user.role`,
`})`,
``,
`Person properties via identify() are NOT the same as event properties via capture().`,
`PII in identify() person properties is expected and recommended by PostHog docs.`,
`Call posthog.reset() on logout to unlink future events from the current user.`,
``,
`### 7. SPA Pageview Tracking`,
`For single-page applications without a framework router, you may need to manually capture pageviews:`,
`posthog.capture('$pageview')`,
`Or use capture_pageview: 'history_change' in the init options for History API based routing.`,
``,
`IMPORTANT: These best practices are MANDATORY. The implementation will fail review if they are not followed.`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra context is SO MEATY. Should it live in the context-mill/skill itself? Maybe we enhance the skill definition system to accept additional local files as framework guidance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im gonna test this approach bc it feels like the right call!! just make sure it doesn't break anything... and fix Python bc I did something similar there :]

];

if (context.hasBundler) {
lines.unshift(`Bundler: ${context.hasBundler}`);
}

return lines;
},
},

ui: {
successMessage: 'PostHog integration complete',
estimatedDurationMinutes: 5,
getOutroChanges: (context) => {
const packageManagerName =
context.packageManagerName ?? 'package manager';
return [
`Analyzed your JavaScript project structure`,
`Installed the posthog-js package using ${packageManagerName}`,
`Created PostHog initialization code`,
`Configured autocapture, error tracking, and event capture`,
];
},
getOutroNextSteps: () => [
'Ensure posthog.init() is called before any capture calls',
'Autocapture tracks clicks, form submissions, and pageviews automatically',
'Use posthog.capture() for custom events and posthog.identify() for users',
'NEVER send PII in event properties (no emails, names, or user content)',
'Visit your PostHog dashboard to see incoming events',
],
},
};
72 changes: 72 additions & 0 deletions src/javascript-web/utils.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import * as fs from 'node:fs';
import * as path from 'node:path';
import { detectAllPackageManagers } from '../utils/package-manager';
import type { WizardOptions } from '../utils/types';

export type JavaScriptContext = {
packageManagerName?: string;
hasTypeScript?: boolean;
hasBundler?: string;
};

/**
* Packages that indicate a specific framework integration exists.
* If any of these are in package.json, we should NOT match as generic JavaScript.
*
* When adding a new JS framework integration to the wizard,
* add its detection package here too.
*/
export const FRAMEWORK_PACKAGES = [
'next',
'nuxt',
'vue',
'react-router',
'@tanstack/react-start',
'@tanstack/react-router',
'react-native',
'@angular/core',
'astro',
'@sveltejs/kit',
] as const;

/**
* Detect the JS package manager for the project by checking lockfiles.
* Reuses the existing package manager detection infrastructure.
*/
export function detectJsPackageManager(
options: Pick<WizardOptions, 'installDir'>,
): string {
const detected = detectAllPackageManagers(options);
if (detected.length > 0) {
return detected[0].label;
}
return 'unknown';
}

/**
* Detect the bundler used in the project by checking package.json dependencies.
*/
export function detectBundler(
options: Pick<WizardOptions, 'installDir'>,
): string | undefined {
try {
const content = fs.readFileSync(
path.join(options.installDir, 'package.json'),
'utf-8',
);
const pkg = JSON.parse(content);
const allDeps: Record<string, string> = {
...pkg.dependencies,
...pkg.devDependencies,
};

if (allDeps['vite']) return 'vite';
if (allDeps['webpack']) return 'webpack';
if (allDeps['esbuild']) return 'esbuild';
if (allDeps['parcel']) return 'parcel';
if (allDeps['rollup']) return 'rollup';
return undefined;
} catch {
return undefined;
}
}
1 change: 1 addition & 0 deletions src/lib/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export enum Integration {

// Language fallbacks
python = 'python',
javascript_web = 'javascript_web',
}
export interface Args {
debug: boolean;
Expand Down
2 changes: 2 additions & 0 deletions src/lib/registry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { SVELTEKIT_AGENT_CONFIG } from '../svelte/svelte-wizard-agent';
import { SWIFT_AGENT_CONFIG } from '../swift/swift-wizard-agent';
import { ANDROID_AGENT_CONFIG } from '../android/android-wizard-agent';
import { PYTHON_AGENT_CONFIG } from '../python/python-wizard-agent';
import { JAVASCRIPT_WEB_AGENT_CONFIG } from '../javascript-web/javascript-web-wizard-agent';

export const FRAMEWORK_REGISTRY: Record<Integration, FrameworkConfig> = {
[Integration.nextjs]: NEXTJS_AGENT_CONFIG,
Expand All @@ -36,4 +37,5 @@ export const FRAMEWORK_REGISTRY: Record<Integration, FrameworkConfig> = {
[Integration.swift]: SWIFT_AGENT_CONFIG,
[Integration.android]: ANDROID_AGENT_CONFIG,
[Integration.python]: PYTHON_AGENT_CONFIG,
[Integration.javascript_web]: JAVASCRIPT_WEB_AGENT_CONFIG,
};
Loading