feat(odin): Allow collecting FCM device token in SDK core #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odin-posthog
changed the title
odin-posthog
force-pushed
the
odin/feature-core-add-push-notification-token-upload
branch
from
295805d to
b727815
Compare
odin-posthog
force-pushed
the
odin/feature-core-add-push-notification-token-upload
branch
from
b727815 to
d55dd96
Compare
odin-posthog
force-pushed
the
odin/feature-core-add-push-notification-token-upload
branch
from
d55dd96 to
b70dfe7
Compare
odin-posthog
force-pushed
the
odin/feature-core-add-push-notification-token-upload
branch
from
f55ff56 to
3fe9042
Compare
Member
|
@odin-posthog thanks for the PR |
Author
|
We don't actually have to split out the changes between "globals" and app SDK, that's just about the releases. See #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
We want to allow customers to send push notifications to their users in workflows. For that, we need to enable the SDK to collect and update the FCM device token that must be used for pushing notifications.
We're not collecting it automatically when initializing so users that don't need this functionality aren't forced to install firebase dependencies, and they have control over which users have their tokens collected (eg. signed-in only)
💚 How did you test it?
Manually in my emulator through the sample app, and with some automated tests (Full changes are in #376)
📝 Checklist