feat: SDK Compliance #362
Open
feat: SDK Compliance #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posthog-android Compliance ReportDate: 2026-01-28 11:01:29 UTC
|
| Test | Status | Duration |
|---|---|---|
| Format Validation.Event Has Required Fields | ✅ | 2358ms |
| Format Validation.Event Has Uuid | ✅ | 2023ms |
| Format Validation.Event Has Lib Properties | ✅ | 2023ms |
| Format Validation.Distinct Id Is String | ✅ | 2020ms |
| Format Validation.Token Is Present | ✅ | 2020ms |
| Format Validation.Custom Properties Preserved | ✅ | 2020ms |
| Format Validation.Event Has Timestamp | ✅ | 2024ms |
| Retry Behavior.Retries On 503 | ❌ | 7027ms |
| Retry Behavior.Does Not Retry On 400 | ✅ | 4024ms |
| Retry Behavior.Does Not Retry On 401 | ✅ | 4022ms |
| Retry Behavior.Respects Retry After Header | ❌ | 7023ms |
| Retry Behavior.Implements Backoff | ❌ | 17022ms |
| Retry Behavior.Retries On 500 | ❌ | 7026ms |
| Retry Behavior.Retries On 502 | ❌ | 7023ms |
| Retry Behavior.Retries On 504 | ❌ | 7027ms |
| Retry Behavior.Max Retries Respected | ❌ | 17023ms |
| Deduplication.Generates Unique Uuids | ✅ | 2041ms |
| Deduplication.Preserves Uuid On Retry | ❌ | 7023ms |
| Deduplication.Preserves Uuid And Timestamp On Retry | ❌ | 12032ms |
| Deduplication.Preserves Uuid And Timestamp On Batch Retry | ❌ | 7032ms |
| Deduplication.No Duplicate Events In Batch | ✅ | 2029ms |
| Deduplication.Different Events Have Different Uuids | ✅ | 2020ms |
| Compression.Sends Gzip When Enabled | ✅ | 2016ms |
| Batch Format.Uses Proper Batch Structure | ✅ | 2017ms |
| Batch Format.Flush With No Events Sends Nothing | ✅ | 2012ms |
| Batch Format.Multiple Events Batched Together | ✅ | 2027ms |
| Error Handling.Does Not Retry On 403 | ✅ | 4021ms |
| Error Handling.Does Not Retry On 413 | ❌ | 4020ms |
| Error Handling.Retries On 408 | ✅ | 7019ms |
Failures
retry_behavior.retries_on_503
Expected at least 3 requests, got 1
retry_behavior.respects_retry_after_header
Expected at least 2 requests, got 1
retry_behavior.implements_backoff
Expected at least 3 requests, got 1
retry_behavior.retries_on_500
Expected at least 2 requests, got 1
retry_behavior.retries_on_502
Expected at least 2 requests, got 1
retry_behavior.retries_on_504
Expected at least 2 requests, got 1
retry_behavior.max_retries_respected
Expected 4 requests, got 1
deduplication.preserves_uuid_on_retry
Need at least 2 requests to check retry
deduplication.preserves_uuid_and_timestamp_on_retry
Expected at least 3 requests, got 1
deduplication.preserves_uuid_and_timestamp_on_batch_retry
Expected at least 2 requests, got 1
error_handling.does_not_retry_on_413
Expected 1 requests, got 2
marandaneto
reviewed
Jan 28, 2026
Comment on lines
+5
to
+11
| branches: [ main, master ] | ||
| paths: | ||
| - 'posthog/**' | ||
| - 'sdk_compliance_adapter/**' | ||
| - '.github/workflows/sdk-compliance-tests.yml' | ||
| pull_request: | ||
| branches: [ main, master ] |
Member
There was a problem hiding this comment.
Suggested change
| branches: [ main, master ] | |
| paths: | |
| - 'posthog/**' | |
| - 'sdk_compliance_adapter/**' | |
| - '.github/workflows/sdk-compliance-tests.yml' | |
| pull_request: | |
| branches: [ main, master ] | |
| branches: [ main ] | |
| paths: | |
| - 'posthog/**' | |
| - 'sdk_compliance_adapter/**' | |
| - '.github/workflows/sdk-compliance-tests.yml' | |
| pull_request: | |
| branches: [ main ] |
we dont have master
marandaneto
reviewed
Jan 28, 2026
| * Default: `null` (SDK creates its own client). | ||
| */ | ||
| @PostHogInternal | ||
| public var httpClient: okhttp3.OkHttpClient? = null |
Member
There was a problem hiding this comment.
Suggested change
| public var httpClient: okhttp3.OkHttpClient? = null | |
| public var httpClient: OkHttpClient? = null |
then just import okhttp3.OkHttpClient
marandaneto
reviewed
Jan 28, 2026
| * @property config The Config | ||
| */ | ||
| internal class GzipRequestInterceptor(private val config: PostHogConfig) : Interceptor { | ||
| public class GzipRequestInterceptor(private val config: PostHogConfig) : Interceptor { |
Member
There was a problem hiding this comment.
Suggested change
| public class GzipRequestInterceptor(private val config: PostHogConfig) : Interceptor { | |
| internal class GzipRequestInterceptor(private val config: PostHogConfig) : Interceptor { |
we can revert this i assume? and run make api again
marandaneto
reviewed
Jan 28, 2026
Comment on lines
+147
to
+148
| println("[ADAPTER] Error parsing request body: ${e.message}") | ||
| e.printStackTrace() |
Member
There was a problem hiding this comment.
i think we can clear all println and printStackTrace?
Member
|
i can see the tests:
but CI didnt fail, is that expected @jose-sequeira ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
We need a language-agnostic way to verify that all PostHog SDKs implement the capture API correctly. The SDK Test Harness provides a shared contract and test runner. This PR integrates it into this SDK.
This adds:
The test harness runs a mock PostHog server, exercises the SDK through the adapter, and verifies behavior matches the contract defined in CONTRACT.yaml (event format, retries, compression, deduplication, etc.).
#skip-changelog
💚 How did you test it?
The compliance tests run as part of this PR's CI. The adapter was also tested locally via
docker-compose.📝 Checklist