-
Notifications
You must be signed in to change notification settings - Fork 0
[RELEASE] v1.1.0 #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] v1.1.0 #153
Conversation
- 우선적으로 Service를 Presentation으로 이동 - Entity를 DomainInterface로 이동
[REFACTOR] 3-Layer 기반 클린아키텍처로 모듈화
- 기존에 Service를 이용하던 곳은 UseCase를 이용하도록 수정 - UseCase를 이용하면서 필요한 의존성 주입 진행 - UseCase는 Repository를 이용하도록 수정 - AppleLogin 객체를 재생성하는 부분을 제거 - Data에 KakaoSDK 추가 및 Presentation에서 KakaoSDK 제거
- 로그인에 필요한 KakaoSDKUser가 빠져서 생긴 문제
- AppleLogin 재시도 시 발생하는 에러로 인해 Service를 재할당 해주던 로직 - 제거 후 별다른 이상이 없어 관련 Flow 제거
[FIX] 카카오 로그인이 동작하지 않던 문제 수정
…pPool/iOS into refactor/#150-layout-abstract # Conflicts: # .gitignore
- SearchResult Section을 유동적으로 사용하던것을 분리함 - 이로 인해 dataSource의 의존성을 줄임
[REFACTOR] 검색 화면 모듈화
…pPool/iOS into refactor/#150-layout-abstract
[FIX] 쓰레드 스위칭이 필요한 코드에만 변경하도록 수정
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
릴리즈 v1.1.0을 위한 PR입니다.