[FIX] 쓰레드 스위칭이 필요한 코드에만 변경하도록 수정

[dongglehada]

📌 이슈

• ImageLoader 개선 #138

✅ 작업 사항

• 이미지로더 중복 코드 제거

🚀 테스트 방식

• xcode instruments CPU Profiler 사용

👀 ETC (추후 개발해야 할 것, 참고자료 등) ->

• 이슈 내부의 코멘트 확인 부탁드립니다!

Summary by CodeRabbit

• Refactor

  • Simplified image loading by removing manual cache checks and relying on the image loader for all image requests.

• Bug Fixes

  • Ensured all image loading completion handlers are executed on the main thread, improving UI consistency and stability.

[coderabbitai]

Walkthrough

The changes remove manual cache checks from the UIImageView extension, delegating all image loading to the shared image loader. In the image loader, completion handlers are now consistently dispatched on the main thread after asynchronous image fetches, ensuring thread safety during UI updates.

Changes

File(s)	Change Summary
Poppool/CoreLayer/Infrastructure/Infrastructure/Extension/UIImageView+.swift	Removed manual memory and disk cache checks; now always delegates image loading to image loader.
Poppool/CoreLayer/Infrastructure/Infrastructure/ImageLoader/ImageLoader.swift	Ensured all completion handlers in async image loading are dispatched on the main thread.

Poem

A hop and a skip, the caches are gone,
Now image loading just hops along.
With main-thread dispatch, UI feels right,
No more cache checks late at night.
The loader takes charge, so swift and keen—
The cleanest code you’ve ever seen!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6ca1bf and 7a1778a.

📒 Files selected for processing (2)

• Poppool/CoreLayer/Infrastructure/Infrastructure/Extension/UIImageView+.swift (1 hunks)
• Poppool/CoreLayer/Infrastructure/Infrastructure/ImageLoader/ImageLoader.swift (1 hunks)

🔇 Additional comments (6)

Poppool/CoreLayer/Infrastructure/Infrastructure/ImageLoader/ImageLoader.swift (3)

101-101: Thread safety improvement for UI updates

Wrapping the success completion handler in DispatchQueue.main.async ensures UI updates happen on the main thread, which is essential for UIKit operations.

---

103-105: Consistent thread handling for error cases

Good improvement to handle error cases on the main thread, maintaining thread safety for UI updates even during failures.

---

108-108: Complete the thread-safety implementation

This change completes the thread-safety improvements by ensuring all completion handlers are called on the main thread, addressing the issue mentioned in PR #138.

Poppool/CoreLayer/Infrastructure/Infrastructure/Extension/UIImageView+.swift (3)

58-70: Code simplification through better responsibility distribution

The code has been simplified by removing redundant thread management. Now that ImageLoader handles dispatching to the main thread, this extension can directly update the UI without additional thread switching.

---

61-69: Proper race condition prevention maintained

The code correctly maintains the URL matching check to prevent race conditions when multiple image requests are in flight, ensuring that only the correct image is displayed.

---

27-71:

Details

✅ Verification successful

Verify performance improvement with the changes

The PR objective mentions using Xcode Instruments' CPU Profiler to test performance. These changes should indeed improve performance by reducing redundant thread switching and cache checks.

---

🏁 Script executed:

#!/bin/bash
# Look for other image loading methods that might need similar optimization

# Find other methods that might involve image loading and thread switching
rg "loadImage.*DispatchQueue\.main" --type swift

Length of output: 50

---

To ensure there aren’t any other image-loading methods or DispatchQueue switches that could benefit from the same optimization, let’s search across the Swift sources for all loadImage( calls and any DispatchQueue.main usage:

---

🏁 Script executed:

#!/bin/bash
echo "🔍 Searching for all loadImage( usages:"
rg 'loadImage\(' -A2 --type swift || true

echo -e "\n🔍 Searching for DispatchQueue.main usages:"
rg 'DispatchQueue\.main' -A2 --type swift || true

Length of output: 12681

---

✅ Consolidated main-thread dispatch in ImageLoader

– We searched all Swift sources for loadImage( and found only the central ImageLoader (in Infrastructure/ImageLoader/ImageLoader.swift) and the UIImageView+ extension under review.
– All UI updates are already dispatched on DispatchQueue.main inside ImageLoader, so the extension no longer incurs redundant thread hops.
– No other custom image-loading methods require the same optimization.

Please use Xcode Instruments’ CPU Profiler to quantify the performance gain, but from code inspection no further changes are needed here.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[0Hooni]

@dongglehada 혹시 코드래빗 준영님이 추가해주신건가요?

저도 이번에 추가해가지고 지금 제 브랜치에 코드래빗 관련 설정 올라갈텐데 준영님도 하신거면 같이 맞추고 수정하면 좋을것 같아서요!!

[dongglehada]

@0Hooni 어라라 아니요..? 따로 소스코드 말고는 수정한 부분은 없습니다 !

[0Hooni]

LGTM!! 수고하셨습니다 ㅎㅎ

[zzangzzangguy]

LGTM! 수고하셨습니다

[0Hooni]

@dongglehada

v1.1.0 릴리즈를 위해 PR Merge 부탁드립니다!