풀스크린맵뷰 애니메이션 제거와 어드민페이지 수정화면 정상화 #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzangzzangguy
added
🐛 fix
dongglehada
approved these changes
May 13, 2025
Member
dongglehada
left a comment
dongglehada
left a comment
There was a problem hiding this comment.
확인완료하였습니다! 궁금한 부분이 하나 있어서 코멘트 남겼습니다 !!
| ) | ||
| let registerVC = PopUpStoreRegisterViewController(nickname: self.nickname) | ||
|
|
||
| registerVC.completionHandler = { [weak self] in |
Member
There was a problem hiding this comment.
Completion 사용의 이유가 있을까요? rx로 동기 비동기를 처리하고 있는 상황인 것 같아서 호기심에 여쭤봅니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈
✅ 작업 사항
🚀 테스트 방식
실기기와 시뮬레이션 교차 검증 확인