[FIX] 서브지역 카테고리 라벨 상단이 짤리던 이슈 수정 #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzangzzangguy
changed the title
zzangzzangguy
changed the title
dongglehada
suggested changes
May 5, 2025
Member
dongglehada
left a comment
dongglehada
left a comment
There was a problem hiding this comment.
팀 룰에 맞게 constant사용 및 then을 사용하여 수정하신 점이 좋습니다!! 다만 일부 코드가 팀룰에 맞지 않거나 이미 있는 요소가 다시 생성된 것 같아서 해당 내용 확인 부탁드릴게요 !!
| import Infrastructure | ||
| import SnapKit | ||
| import Then | ||
| import UIKit |
Member
There was a problem hiding this comment.
import 순서 및 띄워쓰기를 팀 룰에 맞게 수정하면 좋을 것 같습니다 :>
| currentAction = action | ||
| } | ||
| } | ||
| static let identifier = "BalloonChipCell" |
Member
There was a problem hiding this comment.
UICollectionViewCell에 identifiers가 이미 존재하는 것으로 알고 있어서 해당 프로퍼티 사용하면 좋을 것 같습니다!!
디자인시스템 내 UICollectionViewCell+
extension UICollectionViewCell {
static var identifiers: String {
return String(describing: self)
}
}
| } | ||
| static let identifier = "BalloonChipCell" | ||
|
|
||
| private enum Constant { |
Member
There was a problem hiding this comment.
사용할 값들을 Constant로 빼서 사용하는 룰!! 적용된 걸 보니 깔끔해서 좋습니다 :>
…0-fix-truncated-subregion-labels
…hub.com/PopPool/iOS into fix/#130-fix-truncated-subregion-labels # Conflicts: # Poppool/PresentationLayer/Presentation/Presentation/Scene/Map/FillterSheetView/BalloonChipCell.swift
…hub.com/PopPool/iOS into fix/#130-fix-truncated-subregion-labels # Conflicts: # Poppool/PresentationLayer/Presentation/Presentation/Scene/Map/FillterSheetView/BalloonChipCell.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈
✅ 작업 사항
UIButton/PPButton의 기본intrinsicContentSize로는 볼드 폰트의 ascender+descender 높이를 충분히 담지 못하는 문제 확인NSMutableAttributedString에.baselineOffset속성(-1)을 추가하여 약간의 트릭(?) 텍스트를 살짝 아래로 이동시켜 잘림 방지Then체이닝(.then {…},.do {…})으로 가독성 개선inset,fontSize,baselineOffset,checkIconSize등)를enum Constant로 추출🚀 테스트 방식
Filter Sheet 열어 “지역 태그” 버튼 영역 확인
2. 기본(비선택) 상태와 탭(선택) 상태 모두에서
👀 ETC (추후 개발해야 할 것, 참고자료 등) ->