Skip to content

Conversation

@ljeub-pometry
Copy link
Collaborator

What changes were proposed in this pull request?

Fix materialize of self-loops

Why are the changes needed?

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Are there any further changes required?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 2edfb7e Previous: e7b0141 Ratio
large/1k fixed edge updates with varying time and numeric string input 752345 ns/iter (± 3361) 366139 ns/iter (± 853) 2.05
lotr_graph/num_edges 4 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 410 ns/iter (± 3) 1 ns/iter (± 0) 410
lotr_graph/graph_latest 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 9412618 ns/iter (± 154352) 1488726 ns/iter (± 3963) 6.32
lotr_graph_window_100/num_edges 28 ns/iter (± 0) 8 ns/iter (± 0) 3.50
lotr_graph_window_100/num_nodes 437 ns/iter (± 8) 5 ns/iter (± 0) 87.40
lotr_graph_window_100_materialise/materialize 9526640 ns/iter (± 60056) 1623509 ns/iter (± 11102) 5.87
lotr_graph_window_10/has_node_existing 130 ns/iter (± 7) 62 ns/iter (± 11) 2.10
lotr_graph_window_10/iterate nodes 34409 ns/iter (± 230) 10159 ns/iter (± 63) 3.39
lotr_graph_window_10/iterate edges 104478 ns/iter (± 1465) 44638 ns/iter (± 235) 2.34
lotr_graph_window_10/graph_latest 52655 ns/iter (± 1549) 25992 ns/iter (± 4051) 2.03
lotr_graph_window_10_materialise/materialize 6142634 ns/iter (± 58426) 992272 ns/iter (± 4619) 6.19
lotr_graph_subgraph_10pc/has_edge_existing 499 ns/iter (± 5) 87 ns/iter (± 0) 5.74
lotr_graph_subgraph_10pc/num_nodes 341 ns/iter (± 9) 4 ns/iter (± 0) 85.25
lotr_graph_subgraph_10pc/has_node_existing 233 ns/iter (± 2) 33 ns/iter (± 0) 7.06
lotr_graph_subgraph_10pc/iterate nodes 4502 ns/iter (± 25) 810 ns/iter (± 13) 5.56
lotr_graph_subgraph_10pc_windowed/has_node_existing 131 ns/iter (± 7) 63 ns/iter (± 11) 2.08
lotr_graph_subgraph_10pc_windowed/iterate nodes 4465 ns/iter (± 21) 1379 ns/iter (± 3) 3.24
lotr_graph_window_50_layered/num_edges 82055 ns/iter (± 1122) 39599 ns/iter (± 784) 2.07
lotr_graph_window_50_layered/num_nodes 104895 ns/iter (± 1248) 22473 ns/iter (± 5373) 4.67
lotr_graph_window_50_layered/has_node_existing 1351 ns/iter (± 225) 126 ns/iter (± 16) 10.72
lotr_graph_window_50_layered/max_id 119134 ns/iter (± 1419) 28065 ns/iter (± 4781) 4.24
lotr_graph_window_50_layered/max_degree 1993038 ns/iter (± 19288) 293491 ns/iter (± 12447) 6.79
lotr_graph_window_50_layered/iterate nodes 244421 ns/iter (± 911) 17486 ns/iter (± 123) 13.98
lotr_graph_window_50_layered/iterate edges 218524 ns/iter (± 929) 82414 ns/iter (± 161) 2.65
lotr_graph_window_50_layered/max_neighbour_degree 3822359 ns/iter (± 14867) 387161 ns/iter (± 3955) 9.87
lotr_graph_window_50_layered/graph_latest 186105 ns/iter (± 3939) 38280 ns/iter (± 812) 4.86
lotr_graph_window_50_layered_materialise/materialize 20237651 ns/iter (± 150023) 3431565 ns/iter (± 34216) 5.90
lotr_graph_persistent_window_50_layered/num_edges_temporal 592701 ns/iter (± 12874) 206059 ns/iter (± 4061) 2.88
lotr_graph_persistent_window_50_layered/num_nodes 138265 ns/iter (± 1789) 33014 ns/iter (± 1594) 4.19
lotr_graph_persistent_window_50_layered/has_node_existing 1802 ns/iter (± 452) 181 ns/iter (± 98) 9.96
lotr_graph_persistent_window_50_layered/max_id 153885 ns/iter (± 7094) 40704 ns/iter (± 522) 3.78
lotr_graph_persistent_window_50_layered/max_degree 2751420 ns/iter (± 18561) 455511 ns/iter (± 11266) 6.04
lotr_graph_persistent_window_50_layered/iterate nodes 331807 ns/iter (± 1601) 36163 ns/iter (± 124) 9.18
lotr_graph_persistent_window_50_layered/iterate edges 184907 ns/iter (± 471) 89510 ns/iter (± 191) 2.07
lotr_graph_persistent_window_50_layered/max_neighbour_degree 5106551 ns/iter (± 12107) 509190 ns/iter (± 1214) 10.03
lotr_graph_persistent_window_50_layered/graph_latest 285583 ns/iter (± 4141) 60138 ns/iter (± 1129) 4.75
lotr_graph_persistent_window_50_layered_materialise/materialize 49425887 ns/iter (± 1281217) 5197178 ns/iter (± 48277) 9.51
lotr_graph/proto_decode 9712827 ns/iter (± 76940) 1887620 ns/iter (± 26638) 5.15
lotr_graph/proto_encode 9247312 ns/iter (± 53426) 1211698 ns/iter (± 54711) 7.63

This comment was automatically generated by workflow using github-action-benchmark.

@ljeub-pometry ljeub-pometry merged commit 5755d33 into db_v4 Jan 29, 2026
20 checks passed
@ljeub-pometry ljeub-pometry deleted the fix/materialize branch January 29, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants