Minor performance improvements #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed the keys from `"12,13,14"`-style strings to sets of strings. * Replaced subtraction loops with modular arithmetic. * Converted undeclared static methods to `classmethod`s (so subclassing works properly, if that ever happens in the future) * Made module importable (you know; just in case this becomes a really big thing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really neat project! I've made some minor improvements to the bits of code I understand (hopefully this hasn't broken anything!). These include:
"12,13,14"-style strings tosets of strings.classmethods (so subclassing works properly, if that ever happens in the future)That isn't an exhaustive list, but it's got the main points. You don't have to merge this if you don't want to.