Merged
Conversation
1. Added Swagger and Logger Dependencies in pom.xml 2. Added Global Exception Handler to handle Exceptions in OrderService 3. Used Swagger and Logger for endpoints in OrderController
Omar/3 endpoints
…nto Crud-Operations
- Added models for StockReservationRequest and StockReservationResponse - Added OrderPlaced event model for communicating with warehouse and ERP - Implemented RabbitMQ producer and consumer for messaging - Added RabbitMQ configuration and dependency setup
MohammmedAhmed8
requested review from
Aelmeky,
NourAlPha,
YehiaFarghaly,
Copilot and
oaly2
and removed request for
Copilot and
oaly2
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements CRUD operations for orders by updating order cancellation logic, adding new order statuses, and enhancing messaging for order events.
- Enhanced order cancellation logic with additional status checks and integration of order product items into the cancellation event.
- Updated order status enum to include new statuses and renamed an existing status for clarity.
- Added handling for OrderDeliveryFailedEvent in the messaging component and updated dependency version in pom.xml.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/podzilla/order/service/OrderService.java | Adds a condition for canceling orders based on status and maps order products to order items for cancellation events. |
| src/main/java/com/podzilla/order/model/OrderStatus.java | Renames an order status and adds new statuses to support expanded order lifecycle handling. |
| src/main/java/com/podzilla/order/messaging/OrderConsumer.java | Introduces handling for failed order delivery events and updates status usage for courier assignment. |
| pom.xml | Upgrades the version of podzilla-utils-lib to support the updated functionality. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
NourAlPha
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.