Conversation
YehiaFarghaly
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to dependencies, introduces role-based access control for the
PromoCodeController, and modifies the event publishing logic in the cart checkout process. It also updates related unit tests to reflect the changes in event naming.Dependency Updates:
podzilla-utils-libdependency version from1.1.11tov1.1.13inpom.xmlto incorporate the latest features or fixes.Role-Based Access Control:
@AllowedRoles({"ROLE_ADMIN"})annotation to thePromoCodeControllerto enforce that only users with theROLE_ADMINrole can access the admin promotional codes endpoint. [1] [2]Event Publishing Logic:
ORDER_PLACEDtoCART_CHECKEDOUTin theCartServiceto better align with the cart checkout process.Unit Test Updates:
CartServiceTestto use the new event nameCART_CHECKEDOUTinstead ofORDER_PLACED. This ensures consistency with the updated logic inCartService. [1] [2] [3] [4] [5]