Skip to content

Fix cart problemssss#18

Merged
YehiaFarghaly merged 3 commits intodevfrom
fix-cart-problemssss
May 19, 2025
Merged

Fix cart problemssss#18
YehiaFarghaly merged 3 commits intodevfrom
fix-cart-problemssss

Conversation

@NourAlPha
Copy link
Contributor

This pull request includes updates to dependencies, introduces role-based access control for the PromoCodeController, and modifies the event publishing logic in the cart checkout process. It also updates related unit tests to reflect the changes in event naming.

Dependency Updates:

  • Updated the podzilla-utils-lib dependency version from 1.1.11 to v1.1.13 in pom.xml to incorporate the latest features or fixes.

Role-Based Access Control:

  • Added the @AllowedRoles({"ROLE_ADMIN"}) annotation to the PromoCodeController to enforce that only users with the ROLE_ADMIN role can access the admin promotional codes endpoint. [1] [2]

Event Publishing Logic:

  • Changed the event name from ORDER_PLACED to CART_CHECKEDOUT in the CartService to better align with the cart checkout process.

Unit Test Updates:

  • Updated all relevant test methods in CartServiceTest to use the new event name CART_CHECKEDOUT instead of ORDER_PLACED. This ensures consistency with the updated logic in CartService. [1] [2] [3] [4] [5]

@NourAlPha NourAlPha requested a review from YehiaFarghaly May 19, 2025 15:00
@NourAlPha NourAlPha self-assigned this May 19, 2025
@YehiaFarghaly YehiaFarghaly merged commit 4cb3cac into dev May 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants