Add DeliveryAddress DTO and update references in authentication classes#29
Merged
YehiaFarghaly merged 3 commits intodevfrom May 17, 2025
Merged
Add DeliveryAddress DTO and update references in authentication classes#29YehiaFarghaly merged 3 commits intodevfrom
YehiaFarghaly merged 3 commits intodevfrom
Conversation
YehiaFarghaly
approved these changes
May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
DeliveryAddressDTO to thecom.podzilla.auth.dtopackage and updates references across the codebase to use this new class instead of the previously importedDeliveryAddressfromcom.podzilla.mq.events. The changes improve modularity by consolidating theDeliveryAddressclass within the authentication module.Introduction of
DeliveryAddressDTO:DeliveryAddressclass in thecom.podzilla.auth.dtopackage. This class includes fields forstreet,city,state,country, andpostalCode, all annotated with@NotBlankfor validation. It implementsSerializableand uses Lombok annotations for boilerplate code reduction.Updates to DTOs:
com.podzilla.mq.events.DeliveryAddressinSignupRequest,UpdateRequest, andUserDetailsRequestDTOs, as they no longer rely on the externalDeliveryAddressclass. [1] [2] [3]Updates to Services:
UserServiceto use the newDeliveryAddressDTO fromcom.podzilla.auth.dto, replacing the previous import fromcom.podzilla.mq.events. [1] [2]Updates to Tests:
AuthenticationControllerTestandAuthenticationServiceTestto import and use the newDeliveryAddressDTO fromcom.podzilla.auth.dto. [1] [2]