Skip to content

Add DeliveryAddress DTO and update references in authentication classes#29

Merged
YehiaFarghaly merged 3 commits intodevfrom
add-address-dto
May 17, 2025
Merged

Add DeliveryAddress DTO and update references in authentication classes#29
YehiaFarghaly merged 3 commits intodevfrom
add-address-dto

Conversation

@NourAlPha
Copy link
Contributor

This pull request introduces a new DeliveryAddress DTO to the com.podzilla.auth.dto package and updates references across the codebase to use this new class instead of the previously imported DeliveryAddress from com.podzilla.mq.events. The changes improve modularity by consolidating the DeliveryAddress class within the authentication module.

Introduction of DeliveryAddress DTO:

  • Added a new DeliveryAddress class in the com.podzilla.auth.dto package. This class includes fields for street, city, state, country, and postalCode, all annotated with @NotBlank for validation. It implements Serializable and uses Lombok annotations for boilerplate code reduction.

Updates to DTOs:

  • Removed imports of com.podzilla.mq.events.DeliveryAddress in SignupRequest, UpdateRequest, and UserDetailsRequest DTOs, as they no longer rely on the external DeliveryAddress class. [1] [2] [3]

Updates to Services:

  • Updated UserService to use the new DeliveryAddress DTO from com.podzilla.auth.dto, replacing the previous import from com.podzilla.mq.events. [1] [2]

Updates to Tests:

  • Updated test files AuthenticationControllerTest and AuthenticationServiceTest to import and use the new DeliveryAddress DTO from com.podzilla.auth.dto. [1] [2]

@NourAlPha NourAlPha requested a review from a team May 16, 2025 17:44
@NourAlPha NourAlPha self-assigned this May 16, 2025
@YehiaFarghaly YehiaFarghaly merged commit 2887575 into dev May 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants