Fixed scripting defines for dedicated server#884
Open
cabbagegod wants to merge 2 commits intoPlayFab:masterfrom
Open
Fixed scripting defines for dedicated server#884cabbagegod wants to merge 2 commits intoPlayFab:masterfrom
cabbagegod wants to merge 2 commits intoPlayFab:masterfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
Fixed a bug. Still needs to be tested on a Unity version before 2021.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unity has changed how build targets are defined and have set
GetScriptingDefineSymbolsForGroupandSetScriptingDefineSymbolsForGroupfor future deprecation. This introduces a bug in PlayFab, causing the editor settings not to update the scripting defines when a "Dedicated Server" build is selected, which was released in 2021.3.This PR should fix the problem with dedicated servers for versions 2021.3+, and cover backwards compatibility for older Unity versions. Additionally, 2021.2+ should now use the non-deprecated methods for scripting define symbols.
The large use of conditional compilation is due to an oversight(?) from Unity, where this is no easy way to get your current build setting for dedicated servers, because dedicated servers are actually a sub target.