Adding support for umbilic curves#2081
Draft
singh-jaydeep wants to merge 11 commits intoPlasmaControl:rg/NFP_facfrom
Draft
Adding support for umbilic curves#2081singh-jaydeep wants to merge 11 commits intoPlasmaControl:rg/NFP_facfrom
singh-jaydeep wants to merge 11 commits intoPlasmaControl:rg/NFP_facfrom
Conversation
-n_umbilic in grid.py -> N_scaling -UmbilicCurve base class -> FluxSurfaceCurve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to update the umbilic curve PR and address some of the TODOs listed there. The changes are based on my understanding of the paper/original PR, so if anything isn't quite right I can revert it.
Overview:
UmbilicCurveclass toFluxSurfaceCurve, allowing for future representations of curves which by construction lie in a flux surface. Subclasses includeFourierUmbilicCurve, which is the particular parameterization of umbilic curves used in the original paper.m_umbilictoFourierUmbilicCurve, so that the class can represent all curves in the original paper.NFP_umbilic_factorton_umbilicwhen used internally inFourierUmbilicCurve, and toN_scalingwhen used externally in basis and grid classes. Wanted a name which doesn't require knowing about umbilic curves when just working with bases or grids.UmbilicHighCurvatureobjective.Notes:
N_scalingin i/o attributes for grid and basis, and left if for the curve itself to update these in its_set_up().