Add comments about recommeded resolutions to docstrings#1898
Draft
Add comments about recommeded resolutions to docstrings#1898
Conversation
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 3.24 % | 3.891e+03 | 4.017e+03 | 125.95 | 35.14 | 31.23 |
test_proximal_jac_w7x_with_eq_update | -0.52 % | 6.829e+03 | 6.793e+03 | -35.29 | 156.75 | 157.68 |
test_proximal_freeb_jac | -0.16 % | 1.323e+04 | 1.321e+04 | -21.71 | 76.50 | 77.21 |
test_proximal_freeb_jac_blocked | -0.50 % | 7.647e+03 | 7.609e+03 | -37.99 | 67.07 | 67.26 |
test_proximal_freeb_jac_batched | -0.14 % | 7.570e+03 | 7.559e+03 | -10.29 | 67.98 | 69.27 |
test_proximal_jac_ripple | 0.23 % | 7.578e+03 | 7.595e+03 | 17.19 | 68.98 | 69.40 |
test_proximal_jac_ripple_spline | 2.65 % | 3.496e+03 | 3.588e+03 | 92.48 | 70.71 | 71.19 |
test_eq_solve | 2.04 % | 2.001e+03 | 2.041e+03 | 40.72 | 123.64 | 123.25 |For the memory plots, go to the summary of |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1898 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 100 100
Lines 27535 27535
=======================================
Hits 26383 26383
Misses 1152 1152
🚀 New features to boost your workflow:
|
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MagneticFieldclasses that we can give recommendations forOmnigenousFieldandOmnigenityobjectivesResolves #1885