various fixes for scroll wheel #413
Open
+38
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*fix using scroll delta instead axis code *fix lost registering low res axis if it will be used *fix duplicate inverting direction of delta *make scroll behavior more responsive *fix and imprv logging
This was referenced Feb 7, 2024
|
Seems to have fixed the issue where my MX Master 3's scroll wheel would suddenly become unresponsive. Thank you. |
waldyrious
reviewed
Jan 11, 2026
| if (!_input_axis.has_value()) | ||
| return; | ||
|
|
||
|
|
There was a problem hiding this comment.
What are these blank new lines for? 🤔
Here, and in lines 96, 135, etc.
waldyrious
reviewed
Jan 11, 2026
Comment on lines
+124
to
+126
| if (lowres_movement == 0) { | ||
| lowres_movement = hires_remainder > 0 ? 1 : -1; | ||
| } |
There was a problem hiding this comment.
Code style changes like these introduce unnecessary noise in the diff. I'd recommend removing them and keeping the diff focused on the actual behavior changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*fix using scroll delta instead axis code
*fix lost registering low res axis if it will be used *fix duplicate inverting direction of delta
*make scroll behavior more responsive
*fix and imprv logging