Feat/apply patch #46
Open
Feat/apply patch #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pistonight
reviewed
Dec 16, 2025
| ]) | ||
| .stdoe(cu::lv::W) | ||
| .stdin(cu::pio::write(PATCH_FILE)) | ||
| .spawn()? |
Collaborator
There was a problem hiding this comment.
I think you can just do .wait_nz()? instead of .spawn()?.wait()?. _nz means wait for non-zero exit status (will error if command fails)
| cu::bail!("failed to checkout the blessed commit."); | ||
| } | ||
|
|
||
| match patch_rust_std(&rust_path) { |
Collaborator
There was a problem hiding this comment.
cu::check!(patch_rust_std(&rust_path), "failed to apply rust std patches")?;| Install { | ||
| /// Keep the rustc/llvm build output. This may consume a lot of disk space, | ||
| /// but makes it faster when debugging the toolchain | ||
| /// |
Collaborator
There was a problem hiding this comment.
nit: remove extra line
| /// The "blessed" commit hash to use (i.e. tested and will work) | ||
| static RUST_COMMIT: &str = "caadc8df3519f1c92ef59ea816eb628345d9f52a"; | ||
| // This is a patch for the rust stdlib | ||
| // static PATCH_FILE: &'static str = "../../../../patches/rust_std.patch"; |
Collaborator
There was a problem hiding this comment.
nit: remove the commented out lint
| // Copyright (c) 2025 Megaton contributors | ||
|
|
||
| use std::path::{Path, PathBuf}; | ||
| use std::{io::stdout, path::{Path, PathBuf}}; |
| // Copyright (c) 2025 Megaton contributors | ||
|
|
||
| // // This modules handles compiling c/c++/asm/rust code | ||
| // This modules handles compiling c/c++/asm/rust code |
Collaborator
There was a problem hiding this comment.
nit: don't have to fix right now, but module comments start with //!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch our rust stdlib to initialize the environment