Fix method graph panel stability and column behavior#10
Merged
Conversation
Replace the repo root README (which includes VS Code banner and full Taplo README) with a CLI-focused standalone README for the PyPI page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Code blocks render as plain TOML on GitHub and have no syntax coloring on PyPI. Use a hosted screenshot instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backfill CHANGELOG.md with all changes since v0.2.1 (0.3.0–0.3.2 + unreleased), annotate CLI-specific entries with plxt versions, and broaden the title to cover both extension and CLI. Add Changelog URL to pyproject.toml [project.urls] for PyPI sidebar. Add .claude/skills/release/ project skill with detection script, version map reference, and workflow instructions for automated version bumping and changelog updates via /release. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The fix was already shipped in plxt 0.1.4 / ext v0.3.2 but was mislabeled under [Unreleased] with an incorrect future version annotation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Integrate pipelex-agent CLI to provide on-save validation diagnostics for MTHDS files with source-located errors, and add a "Show Method Graph" command that renders the ReactFlow graph in a side panel. Includes CLI resolution (venv, PATH, uv fallback), validation types, source locator, and unit tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use undefined instead of ViewColumn.Beside when revealing an existing panel so it stays in its current column. Add retainContextWhenHidden to preserve webview content when backgrounded. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a file opens in the graph panel's editor group (e.g. user clicks explorer while the graph has focus), close it there and re-open it in the main editor column to keep the graph group dedicated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9942fec934
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
… path Address 6 PR review issues: extract shared processUtils (spawnCli, cancelInflight helpers), cancel all inflight graph jobs on file switch with staleness check, guard against infinite loop when panel is in column 1, add missing warning message in MethodGraphPanel, detect Windows .venv/Scripts path, and gate validator/graph behind child_process availability for browser hosts. Add cliResolver unit tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
registerNodeFeatures was called fire-and-forget, so the showMethodGraph
command could be missing at activation time and import failures were
unhandled. Make registerPipelexFeatures async, await the helper, and
surface errors as warnings.
Fix filename extraction using split('/') which broke on Windows
backslash paths — replace with a regex that handles both separators.
Add staleness guard after fs.promises.readFile so a file switch during
the read doesn't overwrite the current graph with stale HTML.
Add three new test files (processUtils, methodGraphPanel,
pipelexExtension) covering these bugs plus regression guards for
previous fixes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Expose pipelex-agent's --direction flag as a pipelex.graph.direction setting (top_down | left_to_right, default top_down) so users can control the method graph layout direction from VS Code settings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| viewColumn: targetCol, | ||
| preserveFocus: false, | ||
| }); | ||
| return; |
There was a problem hiding this comment.
Infinite-loop guard also blocks MTHDS auto-update
Medium Severity
When the graph panel ends up in column 1 (e.g., user closes the original editor column or drags the panel), the targetCol === panelCol guard correctly prevents an infinite redirect loop — but the early return also prevents the MTHDS auto-update logic at lines 47–52 from ever executing. Switching between .mthds files will no longer refresh the graph, because the handler exits before reaching this.show(newUri). The guard needs to fall through to the auto-update check instead of returning outright.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reveal(undefined)instead ofreveal(ViewColumn.Beside)so the panel stays in its current column when updatingretainContextWhenHidden: trueto preserve webview content when backgroundedTest plan
.mthdsfile, trigger "Show Method Graph".mthdsfiles — the same panel should update in place without jumping🤖 Generated with Claude Code
Note
Medium Risk
Adds new runtime behaviors that execute external CLIs (
pipelex-agent) on save and manage a persistent webview panel, which can impact editor performance/UX and error handling across platforms despite test coverage.Overview
Adds Pipelex Node-host-only features to the VS Code extension: on-save
pipelex-agentvalidation with inline diagnostics, and a new method graph webview (pipelex.showMethodGraph) that stays in its current column, retains state when hidden, redirects “stray” editor opens out of the panel column, and avoids stale async updates via inflight cancellation and staleness checks.Introduces supporting utilities (
cliResolver,processUtils,sourceLocator, shared types) and a comprehensive Vitest suite covering the new behaviors and regressions; activation now awaitsregisterPipelexFeaturesand gracefully skips Node-dependent features in browser hosts.Updates release/process artifacts: bumps extension version to
0.4.0and updatesCHANGELOG.md, adds a/releaseClaude skill (workflow + version map + change detection script), tweaksmake checkto run tests, and refreshes docs/packaging (README example image, dedicated PyPI README wired viapyproject.toml+ new Changelog URL).Written by Cursor Bugbot for commit 26e4bb9. This will update automatically on new commits. Configure here.