Skip to content

[WIN] Fix node module support #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
worstperson wants to merge 2 commits into from
Closed

[WIN] Fix node module support #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7d0cbf
[WIN] Fix node module support
worstperson Jan 18, 2022
969c983
Re-enable Windows test
worstperson Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# disabled windows due node packages issues
# os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: [ '2.x', '3.x', '3.5', '3.6', '3.7', '3.8', '3.9', 'pypy-2.7', 'pypy-3.6', 'pypy-3.7' ]
exclude:
- os: windows-latest
Expand Down
6 changes: 3 additions & 3 deletions js2py/node_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ def _init():
'node -v', shell=True, cwd=DIRNAME
) == 0, 'You must have node installed! run: brew install node'
assert subprocess.call(
'cd %s;npm install babel-core babel-cli babel-preset-es2015 babel-polyfill babelify browserify browserify-shim'
% repr(DIRNAME),
'cd "%s" && npm install babel-core babel-cli babel-preset-es2015 babel-polyfill babelify browserify browserify-shim'
% DIRNAME,
shell=True,
cwd=DIRNAME) == 0, 'Could not link required node_modules'
DID_INIT = True
Expand Down Expand Up @@ -94,7 +94,7 @@ def _get_and_translate_npm_module(module_name, include_polyfill=False, update=Fa
pkg_name += '@' + maybe_version_str
# make sure the module is installed
assert subprocess.call(
'cd %s;npm install %s' % (repr(DIRNAME), pkg_name),
'cd "%s" && npm install %s' % (DIRNAME, pkg_name),
shell=True,
cwd=DIRNAME
) == 0, 'Could not install the required module: ' + pkg_name
Expand Down