Skip to content

fix bug when variable name equals Js #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mie00 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix bug when variable name equals Js #269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f22f4ee
fix bug when variable name equals Js
mie00 Sep 24, 2021
f28b8e6
add Scope, pyjs.*
mie00 Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions js2py/translators/friendly_nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import binascii

from pyjsparser import PyJsParser
from js2py import pyjs
import six
if six.PY3:
basestring = str
Expand All @@ -10,6 +11,7 @@

REGEXP_CONVERTER = PyJsParser()

RESERVED_INTERNAL = set(pyjs.__all__ + ["Js", "Scope"])

def to_hex(s):
return binascii.hexlify(s.encode('utf8')).decode(
Expand Down Expand Up @@ -49,6 +51,8 @@ def get_break_label(label):


def is_valid_py_name(name):
if name in RESERVED_INTERNAL:
return False
try:
compile(name + ' = 11', 'a', 'exec')
except:
Expand Down