Skip to content

Conversation

@wutwasthat
Copy link
Collaborator

Copy link
Member

@ApocalyVec ApocalyVec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I didn't find any issues with this PR. I suggest creating a pull request in pyqtgraph from https://github.com/wutwasthat/pyqtgraph.git@physio, so that this version of pyqtgraph can be officially supported. And the community can benefit from "plotting multiple lines in one call".

Copy link
Member

@ApocalyVec ApocalyVec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error encounter when using stream srate is set to 1366 in the StreamOptionWindow.

To reproduce, start the LSLOutletExample (doesn't matter # channels and its actual srate). Start PhysioLabXR, add the stream, start streaming, open StreamOptionWindow and set the "nominal sampling rate" to 1366. The exception occurs at line 211 of GroupPlotWidget:

Exception('X array and Y matrix must be the same shape--got (119,) and ( ,238).')

These numbers are not always the same, they depend on the srates.

I recommend using test/PerformanceBenchmark.py -> test_stream_visualization_dummy_streams_performance to test if everything checks out. This tests sweeps through streams with different srates.

@wutwasthat
Copy link
Collaborator Author

Error encounter when using stream srate is set to 1366 in the StreamOptionWindow.

To reproduce, start the LSLOutletExample (doesn't matter # channels and its actual srate). Start PhysioLabXR, add the stream, start streaming, open StreamOptionWindow and set the "nominal sampling rate" to 1366. The exception occurs at line 211 of GroupPlotWidget:

Exception('X array and Y matrix must be the same shape--got (119,) and ( ,238).')

These numbers are not always the same, they depend on the srates.

I recommend using test/PerformanceBenchmark.py -> test_stream_visualization_dummy_streams_performance to test if everything checks out. This tests sweeps through streams with different srates.

Fixed. Performance test file seems to be running a very very very long time, not sure if it's suppose to or something is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants