Fix tests and move functionnalities to Experiment Model repository #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and so add ExperimentModel to the baseline
…ctly delete instrumentation after launch
Comment on lines
7
to
8
| #traits : 'TLogger', | ||
| #classTraits : 'TLogger classTrait', |
Contributor
There was a problem hiding this comment.
Finalement je me demande si TLogger n'est pas trop général, au sens où il pourrait y avoir un trait générique comme ça dans Pharo, indépendant de DSSpy.
Est-ce qu'il ne faudrait pas "T-quelquechose-Logger" ?
Contributor
Author
There was a problem hiding this comment.
Oui en effet c'est très générique, on risque d'avoir des conflits !
Vu que c'est rattaché aux expériences, ça pourrait être un truc comme T-ExperimentModel-Logger
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were fixed, so that it will be easier to know when something is broken.
The github workflow was refactored and is now easier.
In addition, the functionnalities put in Experiment Model repository were deleted from DebuggingSpy and the dependancy added in the baseline.