Open
Conversation
added minline and toggle reset buttons
Added tooltips to placeholder and min/max graph buttons
two variables but without node implementation
implemented drag and drop to add data into multi-line graph
implemented play/pause button also cleaned up code
pfrommerd
requested changes
Jan 22, 2022
Comment on lines
+34
to
+36
| if (typeof this.state == "boolean") { | ||
| this.backgroundColor = this.state? "#008000" : "#B22222" | ||
| } |
Collaborator
There was a problem hiding this comment.
This should be done via a class attribute for booleans rather than hardcoding the style
Comment on lines
+120
to
+121
| // if (event.target.type) | ||
| console.log(event.target); |
| series: this.srs, | ||
| realTime: true, | ||
| baseTime: Date.now() - performance.now(), | ||
| xRange: { min: 0, max: 20 * 1000 }, |
Collaborator
There was a problem hiding this comment.
Why is this range hardcoded?
Comment on lines
+176
to
+182
| var yVal = Math.sin(time * 0.002); | ||
| // this.history[0].push({x: time, y: yVal}); | ||
| if (this.live) { | ||
| for (let i = 0; i < this.history.length; i++) { | ||
| this.history[i].push({x : time, y : (yVal + i)}); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Can we use real subscription data by attaching a subscriber instead of generating data?
| computed: { | ||
| header() { | ||
| return ( | ||
| "GraphMinMax: " + (this.variables[0] ? this.variables[0].getPretty() : "") |
Collaborator
There was a problem hiding this comment.
Why only the first variable?
Comment on lines
+4
to
+30
| <div class="graph-controls"> | ||
| <NumberField v-model="timespan" @input="updateTimespan" /> | ||
| <FlatButton | ||
| icon="clock" | ||
| :class="{ controlActive: useTimespan }" | ||
| @click="useTimespan = !useTimespan" | ||
| title="Use Timespan" | ||
| /> | ||
| <FlatButton | ||
| icon="play" | ||
| :class="{ controlActive: live }" | ||
| @click="toggleLive" | ||
| title="Play" | ||
| /> | ||
| <FlatButton | ||
| icon="arrow-alt-circle-up" | ||
| :class="{ controlActive: live }" | ||
| @click="toggleMax" | ||
| title="Reset Max Line" | ||
| /> | ||
| <FlatButton | ||
| icon="arrow-alt-circle-down" | ||
| :class="{ controlActive: live }" | ||
| @click="toggleMin" | ||
| title="Reset Min Line" | ||
| /> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
This should probably not be a separate component, but a flag on the existing graph component so that you can have expanded tools (that way we reduce code duplication) between this file and Graph.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented more graphing types, including time graph with min-max lines, drag-and-drop variables onto graphs, and colored boolean display.