This repository was archived by the owner on Jan 11, 2026. It is now read-only.
Fixes for recent language-php package #420
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With multiple matches but with none of them having isMethod getMemberContext would return the whole array instead of a single value or undefined causing errors in the calling code paths
Changes made to the language-php syntax package rendered the used selectors broken. With this the selectors now match as intended again.
Changes made to the language-php syntax package rendered the used selectors broken. With this the selectors now match as intended again.
Selectors were not matching class constants correctly. Also constants would be treated the same as methods although not having a declaringStructure but declaringClass instead. See also previous commits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last update of this package in 2017 the https://github.com/atom/language-php package has undergone significant changes breaking the functionality of
atom-autocomplete-php. This is mostly to a changed structure / naming of CSS selectors / syntax scopes.This PR updates appropriately to make
atom-autocomplete-phpwork with a recentlanguage-php/atomversion.