Fixes issues #2, #7, #8, #9, #11#10
Open
tempelmann wants to merge 34 commits intoPedestrianSean:masterfrom
Open
Fixes issues #2, #7, #8, #9, #11#10tempelmann wants to merge 34 commits intoPedestrianSean:masterfrom
tempelmann wants to merge 34 commits intoPedestrianSean:masterfrom
Conversation
…alue when parsing (and running) a script.
…to unresolved issue PedestrianSean#8, though.
…r `setProperty:` raised an error, invoking longjmp and thereby skipping the call to objc_release. This fix uses the __unsafe_unretained modifier to tell ARC not to call retain nor release at all in these functions, thereby circumventing the issue. The code also now compiles properly with disabled ARC, which was mainly needed for debugging but can be left in there, just in case someone else feels the need for this.
…w `parseResult` and block functions.
…` and `parseURL:` functions
…, not lua_tonumber).
Author
|
BTW, it might also be a smart move to update the version info (in the podspec) once the changes are merged. And maybe add the version number also to the README.md |
Author
|
Yikes, hold on - there's still something wrong. Depending on the diagnostics settings in the Test scheme the code fails or succeeds. Need to debug that first. |
It was wrong to use the `__unsafe_unretained` attribute on the value, as it's autoreleased and might get released too soon. The proper way would be to manually add a retain and release call during its use, but my testing did confirm that I'd end up with a leak if I leave out the release call. And those values are getting autoreleased anyway, even with ARC enabled, and even with a forced error exit (thru longjmp), so the safest solution appears to be to revert my change and leave ARC handle this one.
Author
|
Okay, now it should be ready for merging. |
Author
|
Now also includes fix for #11 |
tempelmann
changed the title
…the (probably impossible) case of calling setArgumentAt with size=0 from `callMethod:withArgs:onInstance:` for the null'd args.
…lue so that it can be used with Lua's date functions.
…tion called from Lua would give wrong results, on Apple Silicon (ARM)
Adding support for callable objects. This also changes the min Xcode version to Xcode 11 and min macOS version to 10.13.
…so that it open again in Xcode 10.1 and builds for macOS 10.10 when used with Xcode 13.x or earlier.
…me LuaExport in order to allow the user to replace it with a custom type
…rray) index is now retrieved as an `integer` instead of a `number` type.
…ted _after_ LuaContext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also brings Lua's source code up-to-date