Open
Conversation
Owner
|
Hey thanks for the pull request, I haven't tested or fully reviewed it yet as I am busy. However, couple of quick suggestion, remove make sure you are following the PEP8 style guidelines, including the naming convention. I'll free up myself in a month or two, and review the code properly before merging. Till then thank you for your patience and understanding |
fixed the time between each frame as it was using sleep.time() which gave me trouble as the videos i was playing was not in the correct frame rate i used a simple module to correct the frame time which takes count of the time code take to run. i also put the module into the project it is a simple module i wrote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the seek function so it is precise so it dose not round it to the nearest 5 seconds i also added a var for speeding or slowing down the footage