Conversation
Now the lag is registered globally (and not only the delta time to the frame before), which allows to skip frames or to sleep more precisely, if lags accumulate slowly Tested on a 120fps 1080p video, it skipped a lot of frames but the video speed was accurate. On small SD videos, it was displaying the right framerate, without skip and without going too fast.
|
Hi, thank you for creating the pull request. I am busy this month. I'll try to look into this as soon as I am free. Thank you. |
|
Hi @havetc sorry for the late reply, I just got freed from work. I tested with a few files but it lags a little or sometimes feels glitchy, maybe because it's skipping too many frames. Would you be able to fix that and let me know? I'll test it again and go for the merge. Also, you can test it with https://pixabay.com/videos/starry-sky-mountains-milky-way-169951/ and try with different resolutions. |
|
I'll close this pull request and merge this with pull #34 since both are similar. We'll continue there. |
|
Do you want me to add this to #34? I'm not sure what you want me to do. |
|
Now that #34 is merged, I suggest retesting this branch: A lot of the felt glitchyness should be gone for very big videos, and for both small and big video the speed of reading should be corrected |
I thinks that it should solve issue #15 , on my system I have no more-slow mo videos (for big resolution and high fps source) or increased speed ones (for small videos with low source fps and displayed in a tiny window).
Now the lag is registered globally (and not only the delta time to the frame before), which allows to skip frames or to sleep more precisely, if lags accumulate slowly
Tested on a 120fps 1080p video, it skipped a lot of frames but the video speed was accurate. On small SD videos, it was displaying the right framerate, without skip and without going too fast.