Skip to content

Initialize Net::HTTP::Post with URI instead of string#28

Open
marcboquet wants to merge 1 commit intoPatreon:masterfrom
Kit:http-req
Open

Initialize Net::HTTP::Post with URI instead of string#28
marcboquet wants to merge 1 commit intoPatreon:masterfrom
Kit:http-req

Conversation

@marcboquet
Copy link

Initializing it with a string causes path to be incorrect:

url = URI.parse('https://www.patreon.com/api/oauth2/token')
req = Net::HTTP::Post.new(url.to_s)
req.path
# => "https://www.patreon.com/api/oauth2/token"

As opposed to

url = URI.parse('https://www.patreon.com/api/oauth2/token')
req = Net::HTTP::Post.new(url)
req.path
# => "/api/oauth2/token"

ruby-doc for Net::HTTP::Post shows initialization using a URI too.

Initializing with a string causes apm-agent-ruby to raise with URI::InvalidURIError. Related issue: elastic/apm-agent-ruby#834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments