API v2

[maximeCony]

Update Ruby lib to APIv2.

The generation code lives in https://github.com/Patreon/patreon_py/pull/18680

Note to reviewer

It should be easier to look at each commit individually.

Inspiration: Patreon/patreon-python#28

[kourge]

This desugars to:

if not count_not_passed
  params["page[count]"] = (count || 10)
end

When this method is:

• Called with count set to 3, then count_not_passed == false, count == 3. This sets params["page[count]"] to 3 || 10, which evaluates to 3.
• Called with count set to nil, then count_not_passed == false, count == nil. This sets params["page[count]"] to nil || 10, which evaluates to 10.
• Called without count, then count_not_passed == true, count == nil. This doesn't set params["page[count]"] at all.

It looks like the intent is to provide three choices?

1. Use the count specified.
2. Use default count.
3. Omit count.

If this triple-choice is to stay, I recommend turning the rest of the optional arguments into keyword args. Depending on the minimum Ruby version supported, we could either use real Ruby keyword args, or simulate them with a hash, as is a long-time traditional in older versions of Ruby.

[maximeCony]

Great catch and great explanation! Looking at the python lib I don't even think we need to provide a default. I will update the logic to:

1. Use the count specified.
2. Omit count.

[kourge]

Although this Enum utility comes from an external source, I'm also not convinced that const_missing is the right way to implement enums.

The instance-variant of const_missing, which is the much more popular method_missing, has a companion method called Object#respond_to_missing?. It's meant to act as a fallback for respond_to?. There's no exact const-variant of respond_to_missing?, but one way to work around it is to turn this model inside out: instead of using const_missing to return a value for a constant that does not otherwise exist, use const_set to define a constant once. For enumerating all constants — something that methods like each, all, all_to_hash rely on — either the built-in Module#constants can serve that purpose, or, to keep them separate from other non-code-gen'd constants, we can maintain an array of @@enum_constants.

[maximeCony]

Although this Enum utility comes from an external source, I'm also not convinced that const_missing is the right way to implement enums.

Do you think it is worth creating a separate PR to address that? Also wondering if there is a ruby gem that we could want to use.

[kourge]

Yes, the author of that snippet has created a separate ruby-enum gem that does this right.

Edit: Yes, this can be addressed in another PR.

[kourge]

I assume all changes to README.md here will also be ported over to its template source?

[maximeCony]

I assume all changes to README.md here will also be ported over to its template source?

Yep! (Thanks for the reminder 😉)