Skip to content

Fix test module code style #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mamadaliev wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix test module code style #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
635ea6a
Optimize imports
mamadaliev Aug 3, 2019
4fd4ca6
Fix assertion to simplify
mamadaliev Aug 3, 2019
be1f069
Fix property access modifier to private
mamadaliev Aug 3, 2019
a198456
Remove "Exception" from "testAuthorizationURL" throws list
mamadaliev Aug 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/test/java/com/patreon/PatreonAPITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
import org.apache.http.NameValuePair;
import org.apache.http.client.utils.URLEncodedUtils;
import org.mockito.ArgumentCaptor;
import org.mockito.Matchers;
import org.mockito.Mockito;
import org.powermock.api.mockito.PowerMockito;

import java.nio.charset.Charset;
import java.util.Arrays;
Expand All @@ -20,9 +18,7 @@

import static org.mockito.Matchers.anyString;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;

public class PatreonAPITest extends TestCase {
private static final String MOCK_TOKEN = "some token";
Expand All @@ -44,7 +40,7 @@ public void testFetchCampaigns() throws Exception {
Campaign campaign = campaignResponse.get().get(0);
assertEquals("70261", campaign.getId());
assertEquals("/bePatron?c=70261", campaign.getPledgeUrl());
assertEquals(false, campaign.isChargedImmediately());
assertFalse(campaign.isChargedImmediately());
assertEquals("212633030584565760", campaign.getDiscordServerId());
assertEquals("32187", campaign.getCreator().getId());
assertEquals(3, campaign.getGoals().size());
Expand Down
7 changes: 2 additions & 5 deletions src/test/java/com/patreon/PatreonOAuthTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.patreon;

import junit.framework.TestCase;
import org.apache.commons.io.Charsets;
import org.apache.commons.io.IOUtils;
import org.jsoup.Connection;
import org.jsoup.Jsoup;
Expand All @@ -10,8 +9,6 @@
import org.jsoup.nodes.Element;
import org.junit.runner.RunWith;
import org.mockito.Mockito;
import org.mockito.invocation.InvocationOnMock;
import org.mockito.stubbing.Answer;
import org.powermock.api.mockito.PowerMockito;
import org.powermock.core.classloader.annotations.PrepareForTest;
import org.powermock.modules.junit4.PowerMockRunner;
Expand All @@ -21,13 +18,13 @@
@RunWith(PowerMockRunner.class)
@PrepareForTest({Jsoup.class, Document.class, HttpConnection.class, Connection.Response.class})
public class PatreonOAuthTest extends TestCase {
PatreonOAuth oauth = new PatreonOAuth(
private PatreonOAuth oauth = new PatreonOAuth(
"a client id",
"your secret",
"your redirect URI"
);

public void testAuthorizationURL() throws Exception {
public void testAuthorizationURL() {
String url = oauth.getAuthorizationURL();
assertEquals("https://www.patreon.com/oauth2/authorize?response_type=code&client_id=a+client+id&redirect_uri=your+redirect+URI", url);
}
Expand Down