Skip to content

Conversation

@jhfgloria
Copy link
Contributor

Description

Flatten the configuration of the plugins so they're defined once and shared across plugin consumers. This alleviates some of the @visibility levels on some properties that were being redacted on logs. The new @visibility levels are specified one by one and are more accurate. Also, this PR removes the need for @pagerduty/backstage-plugin-scaffolder-actions and @pagerduty/backstage-plugin-entity-processor to have the same configurations since they should be set in the backend plugin.

breaking change: During initialisation of a Backstage instance there is a merge step where all configurations are examined. Different @visibility levels on the same configurations will be considered an error and the instance will be faulty. This means that for users of more than one plugin, they will need to update all in tandem for the versions specified in the changeset.

Issue number: #28

Affected plugin

  • backstage-plugin
  • backstage-plugin-backend
  • backstage-plugin-scaffolder-actions
  • backstage-plugin-entity-processor

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes have been tested in dark theme
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@jhfgloria jhfgloria self-assigned this Dec 5, 2025
@jhfgloria jhfgloria requested a review from a team as a code owner December 5, 2025 14:15
sandornagy517
sandornagy517 previously approved these changes Dec 5, 2025
@jhfgloria jhfgloria changed the base branch from main to next December 5, 2025 14:21
@jhfgloria jhfgloria dismissed sandornagy517’s stale review December 5, 2025 14:21

The base branch was changed.

@jhfgloria
Copy link
Contributor Author

This one should not be merged until we understand how to release it in Portal without disrupting users who may not be aware of the fact that they need to update ALL the plugin offering. Otherwise, they won't be able to update the other plugins even if prompted by the platform. This results from the merge configuration step where @visibility levels are cross checked and installation fails if these differ.

@jhfgloria jhfgloria changed the title Fix: correct visibility configuration fix: correct visibility configuration Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants