fix: correct visibility configuration #106
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flatten the configuration of the plugins so they're defined once and shared across plugin consumers. This alleviates some of the
@visibilitylevels on some properties that were being redacted on logs. The new@visibilitylevels are specified one by one and are more accurate. Also, this PR removes the need for@pagerduty/backstage-plugin-scaffolder-actionsand@pagerduty/backstage-plugin-entity-processorto have the same configurations since they should be set in the backend plugin.breaking change: During initialisation of a Backstage instance there is a merge step where all configurations are examined. Different
@visibilitylevels on the same configurations will be considered an error and the instance will be faulty. This means that for users of more than one plugin, they will need to update all in tandem for the versions specified in the changeset.Issue number: #28
Affected plugin
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.