Skip to content

Conversation

@PSulf
Copy link
Owner

@PSulf PSulf commented May 9, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Finished all required sections of assignment_2.ipynb, including:

  • Reading CSV data
  • Calculating mean, max, and min per patient
  • Detecting data issues using the provided check_zeros() function

What did you learn from the changes you have made?

I practiced NumPy operations like np.mean, np.max, and np.min over patient datasets. Also got more comfortable with file handling and debugging path issues in Jupyter.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I briefly thought of using pandas for summarization, but stuck strictly with NumPy to follow course expectations.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Yes. Jupyter kept giving FileNotFoundErrors due to relative path confusion — solved it by checking my Git Bash working directory and using "../../" to align paths correctly. Also had to do git pull --rebase before push due to sync issues.

How were these changes tested?

I ran each function block-by-block and confirmed:

  • File loads properly
  • Summary arrays contain 60 values
  • detect_problems() returns False for the first file

A reference to a related issue in your repository (if applicable)

None at the moment

Checklist

  • I can confirm that my changes are working as intended

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please make the following changes:

  1. Please refer to following thread of slack https://uoft-dsi-certificates.slack.com/archives/C08JWD6RRU3/p1747084222526419
    Changes to assignment_1.ipynb should not be included in this pull request.

  2. There are two definitions of detect_problems functions. Please remove the duplication.

  3. The function check_zeros should be defined before detect_problems.

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed! Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants