Update Manager and stats to correctly store information about processing#1
Open
ondrejbartas wants to merge 19 commits intomasterfrom
Open
Update Manager and stats to correctly store information about processing#1ondrejbartas wants to merge 19 commits intomasterfrom
ondrejbartas wants to merge 19 commits intomasterfrom
Conversation
ondrejbartas
commented
Oct 11, 2017
lib/exq/manager/server.ex
Outdated
| worker_init = [ | ||
| ["SADD", JobQueue.full_key(state.namespace, "processes"), name], | ||
| ["HSET", name, "quiet", "false"], | ||
| ["HSET", name, "info", Poison.encode!(%{ hostname: state.node_id, started_at: state.started_at, pid: "#{string_pid(state)}", concurrency: 5, queues: state.queues})], |
Member
Author
There was a problem hiding this comment.
fix concurency to get real value
ondrejbartas
commented
Oct 11, 2017
lib/exq/redis/job_stat.ex
Outdated
| def add_process(redis, namespace, process_info, serialized_process \\ nil) do | ||
| instr = add_process_commands(namespace, process_info, serialized_process) | ||
| Connection.qp!(redis, instr) | ||
| IO.inspect(instr) |
ondrejbartas
commented
Oct 11, 2017
| end | ||
| def add_process(redis, namespace, process_info, serialized_process \\ nil) do | ||
| instr = add_process_commands(namespace, process_info, serialized_process) | ||
| Connection.qp!(redis, instr) |
ondrejbartas
commented
Oct 11, 2017
lib/exq/redis/job_stat.ex
Outdated
| processes = JobQueue.full_key(namespace, "processes") | ||
| instr = Connection.smembers!(redis, processes) | ||
| |> Enum.filter(fn(key) -> key =~ "#{hostname}:" end) | ||
| |> Enum.map(fn(key) -> ["SREM", processes, key] end) |
Member
Author
There was a problem hiding this comment.
remove also workers
ondrejbartas
commented
Oct 11, 2017
lib/exq/redis/job_stat.ex
Outdated
| end | ||
|
|
||
| defp supervisor_worker_name(namespace, process_info) do | ||
| JobQueue.full_key(namespace, "#{process_info.hostname}:#{:erlang.pid_to_list(:sys.get_state(Exq).pid)}") |
Member
Author
There was a problem hiding this comment.
get pid of main process by different way
ondrejbartas
force-pushed
the
fix-sidekiq5
branch
3 times, most recently
from
fc28429 to
adbd0d7
Compare
[skipci]
Remove password from error logging
make redis module name and start_link args configurable
add note about sentinel support
TondaHack
force-pushed
the
fix-sidekiq5
branch
from
adbd0d7 to
3aa19a9
Compare
TondaHack
force-pushed
the
fix-sidekiq5
branch
from
3aa19a9 to
28da15d
Compare
TondaHack
force-pushed
the
fix-sidekiq5
branch
from
650550c to
e7c2058
Compare
TondaHack
force-pushed
the
fix-sidekiq5
branch
from
34363ce to
ea33b33
Compare
TondaHack
force-pushed
the
fix-sidekiq5
branch
from
ea33b33 to
2919ebc
Compare
TondaHack
force-pushed
the
fix-sidekiq5
branch
from
f01e84f to
ab88ee5
Compare
TondaHack
force-pushed
the
fix-sidekiq5
branch
from
ab88ee5 to
94fdc05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing jobs