Skip to content

Validate test binaries upon code changes #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
elizabethteng wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Validate test binaries upon code changes #780

elizabethteng wants to merge 23 commits into from

Conversation

@elizabethteng
Copy link
Contributor

@elizabethteng elizabethteng commented Dec 18, 2025 •
edited
Loading

  • enhance 1Z_sun_binaries_suite.py to save evolution data to h5 file in ./outputs
  • update evolve_binaries.sh to reflect output saving
  • write validate_binaries.sh (script for single-line command for comparing branches)
    • call evolve_binaries.sh for new branch
    • call compare_runs.py and save output to file in ./outputs for difference report
    • give option to compare two branches and evolve both, or compare new branch to passed h5 file
  • write compare_runs.py (compares two h5 files and reports differences)
    • outline
    • quantitative differences beyond thresholds
    • qualitative differences to evolution
    • differences to warnings and errors
  • generate baseline.h5
  • extend to other metallicities

@elizabethteng elizabethteng changed the title Create validate_binaries.sh Validate test binaries upon code changes Dec 18, 2025
elizabethteng and others added 10 commits December 18, 2025 09:18
@elizabethteng
Update 1Zsun_binaries_suite.py to fix args in function calls
91c3d5f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8239290 
for more information, see https://pre-commit.ci
@elizabethteng
Update authors
1a01213
@elizabethteng
remove alarm calls that were never set
e967e01 
Removed signal alarm handling in exception block.
@elizabethteng
Enhance evolve_binaries.sh for better logging and error handling
e5c07ce 
Updated the script to log output and check for errors.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1a82ac8 
for more information, see https://pre-commit.ci
@elizabethteng
Fix argument passing for evolve_binaries function
5525ea8
@elizabethteng
fill in all code for validate_binaries.sh
138d804 
Updated script to accept branch and suffix as arguments, streamlined output file naming.
@elizabethteng
starting point of compare_runs.py for comparing two h5 files
12a528e
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9140a20 
for more information, see https://pre-commit.ci
maxbriel
maxbriel reviewed Dec 20, 2025
View reviewed changes
dev-tools/script_data/1Zsun_binaries_suite.py

except Exception as e:
# turn off binary alarm in case of exception
signal.alarm(0)
Copy link
Collaborator

@maxbriel maxbriel Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elizabethteng I think these are now alright to remove, because we've added the following to binarystar.evolve():

        finally:
            signal.alarm(0)     # turning off alarm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxbriel maxbriel maxbriel left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@elizabethteng elizabethteng

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elizabethteng @maxbriel