feat(from_HBJSON): Convert PO Models to WUFI XML #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created new _type_utils.py module with type-safe wrapper functions for accessing energy properties - These wrappers have proper type hints that force linter errors when None handling is missing - Updated cleanup.py, create_schedules.py, create_rooms.py, create_variant.py, create_building.py, and create_assemblies.py to use the new wrappers - Modified merge functions to gracefully handle missing energy properties by creating default objects with warnings - All functions now properly handle cases where room.properties.energy attributes are None - No function behavior changes - only added proper type-hinting and error handling - Added test script for Model 1.hbjson which has None energy properties
- Support using `from_HBJSON` on PO models which do not have Honeybee-Energy attributes - Cleaned up and standardized import statements and type hints across PHX modules, removing unused imports and updating references for clarity and maintainability. - Minor bug fixes and improved error handling in Honeybee-related utilities and face merging logic. No functional changes to core algorithms. - format (isort, black, ruff)
|
🎉 This PR is included in version 1.52.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_HBJSONon PO models which do not have Honeybee-Energy attributes