Skip to content

Fix nan in Minuit #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PFLeget merged 1 commit into from
Aug 22, 2025
Merged

Fix nan in Minuit #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions treegp/two_pcf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,22 +125,25 @@ def chi2(self, param):
:param param: list of non-linear parameters to search.
(correlation lenght, e1, and e2).
"""
model = self._model_skl(1.0, param[0], param[1], param[2])
if model is None:
if not np.isfinite(np.sum(param)):
self.chi2_value = np.inf
else:
model = model[self.mask]
F = np.array([model, np.ones_like(model)]).T
FWF = np.dot(F.T, self.W).dot(F)
Y = self.flat_data[self.mask].reshape((len(model), 1))
self.alpha = np.linalg.inv(FWF).dot(np.dot(F.T, self.W).dot(Y))
self.alpha[0] = abs(self.alpha[0])
self.residuals = self.flat_data[self.mask] - (
(self.alpha[0] * model) + self.alpha[1]
)
self.chi2_value = self.residuals.dot(self.W).dot(
self.residuals.reshape((len(model), 1))
)
model = self._model_skl(1.0, param[0], param[1], param[2])
if model is None:
self.chi2_value = np.inf
else:
model = model[self.mask]
F = np.array([model, np.ones_like(model)]).T
FWF = np.dot(F.T, self.W).dot(F)
Y = self.flat_data[self.mask].reshape((len(model), 1))
self.alpha = np.linalg.inv(FWF).dot(np.dot(F.T, self.W).dot(Y))
self.alpha[0] = abs(self.alpha[0])
self.residuals = self.flat_data[self.mask] - (
(self.alpha[0] * model) + self.alpha[1]
)
self.chi2_value = self.residuals.dot(self.W).dot(
self.residuals.reshape((len(model), 1))
)

return self.chi2_value

Expand Down