Implemented Various Distance Metric by Modernbeast02 · Pull Request #107 · PEC-CSS/slowmokit

Modernbeast02 · 2023-02-14T14:15:56Z

Resolved Issue #95

This reverts commit 16031e4.

uttammittal02

Add docs for distance metrics
Resolve the conflicts
Shift all the files from neighbours to metrics

src/slowmokit/methods/neighbors/distance_metric/distance_metric.cpp

src/slowmokit/methods/neighbors/distance_metric/distance_metric.hpp

uttammittal02

Few more changes

src/slowmokit/methods/metrics/distance_metric/distance_metric.cpp

uttammittal02

Add the docs for distance metrics bruh

uttammittal02

Last change ig

uttammittal02 · 2023-02-15T12:47:18Z

src/slowmokit/methods/metrics/distance_metric/distance_metric.cpp

+  int n = x.size();
+  for (int i = 0; i < n; i++)
+  {
+    distance += std::pow(x[i] - y[i], power);


Use std::abs(x[i] - y[i]) instead.
Otherwise there might be a problem in case of odd values of p.

uttammittal02

Lgtm

Ishwarendra · 2023-02-15T13:37:52Z

docs/methods/metrics/distance_metric.md

+## Manhattan Distance
+Manhattan Distance is the sum of absolute differences between points across all the dimensions.
+
+## Manhattan Distance


Change distance name to minkowski

Ishwarendra · 2023-02-15T13:41:26Z

docs/methods/metrics/distance_metric.md

+Minkowski Distance is the generalized form of Euclidean and Manhattan Distance.
+
+## Cosine Similarity
+Cosine similarity is a metric, helpful in determining, how similar the data objects are irrespective of their size.


Add sentence like

lesser is the cosine similarity, more similar are two points.

for all four metric.

Ishwarendra · 2023-02-15T13:45:18Z

src/slowmokit/methods/metrics/distance_metric/distance_metric.cpp

+#include "distance_metric.hpp"
+
+template<class T>
+DistanceMetric<T>::DistanceMetric(std::vector<T> &x, std::vector<T> &y)


Suggested change

DistanceMetric<T>::DistanceMetric(std::vector<T> &x, std::vector<T> &y)

DistanceMetric<T>::DistanceMetric(const std::vector<T> &x, const std::vector<T> &y)

We don't want user to feel insecure about their data. Use const. (No need to update in .hpp file)

const in cpp but not in hpp?

.hpp file

void f(int);

.cpp file

void f(const int param1) { return; }

is valid and recommended.

Ishwarendra · 2023-02-15T13:47:30Z

src/slowmokit/methods/metrics/distance_metric/distance_metric.cpp

+DistanceMetric<T>::DistanceMetric(std::vector<T> &x, std::vector<T> &y)
+{
+  this->x = x;
+  this->y = y;


Suggested change

DistanceMetric<T>::DistanceMetric(std::vector<T> &x, std::vector<T> &y)

{

this->x = x;

this->y = y;

DistanceMetric<T>::DistanceMetric(std::vector<T> &x, std::vector<T> &y) : x(x), y(y)

{

Use initialiser list, they are faster.

Ishwarendra · 2023-02-15T13:50:02Z

src/slowmokit/methods/metrics/distance_metric/distance_metric.hpp

+ * @param x
+ * @param y


Add short statement describing x and y

Ishwarendra · 2023-02-15T13:53:07Z

src/slowmokit/methods/metrics/distance_metric/distance_metric.hpp

+
+  /**
+   * @param power The order of the norm
+   * @returns minkowski distance between the two vectors


Suggested change

* @returns minkowski distance between the two vectors

* @returns minkowski distance between the two vectors

* @throws ...

power < 1 is not allowed..

Ishwarendra · 2023-02-15T14:07:39Z

src/slowmokit/methods/metrics/distance_metric/distance_metric.cpp

+
+template<class T> double DistanceMetric<T>::magnitude(std::vector<T> &x)
+{
+  double result = 0;


Suggested change

double result = 0;

long double result = 0;

double might overflow

Ishwarendra · 2023-02-15T14:07:55Z

src/slowmokit/methods/metrics/distance_metric/distance_metric.cpp

+
+template<class T> double DistanceMetric<T>::cosineSimilarity()
+{
+  double dotProduct = 0;


Suggested change

double dotProduct = 0;

long double dotProduct = 0;

Ishwarendra · 2023-02-15T14:10:14Z

src/slowmokit/methods/metrics/distance_metric/distance_metric.cpp

+
+template<class T> double DistanceMetric<T>::euclidean()
+{
+  double distance = 0;


Suggested change

double distance = 0;

long double distance = 0;

You will have to downcast long double to double finally. use std::dynamic_cast

UPDATE: Do this wherever I have added double -> long double comments

src/slowmokit/methods/metrics/distance_metric/distance_metric.hpp

Ishwarendra · 2023-02-15T14:21:01Z

Fix conflicts as well. @Modernbeast02

harshjohar

Commit names should be relevant from next time

ken1000minus7

I would say it would be better to make all functions static instead of passing the vectors as property and then calling respective functions

harshjohar

Revert CMakeLists.txt and don't change it in future models

Modernbeast02 and others added 22 commits February 7, 2023 19:22

Resolved Issue PEC-CSS#64

4900b40

Fixed All Operators Issue#64

341ebc0

Merge branch 'PEC-CSS:main' into main

34f6cc2

Taken Pull and Merged

0c12221

Merge branch 'main' of https://github.com/Modernbeast02/PWOC_slowmokit

d6d077b

Resolved Issue#81

16031e4

Revert "Resolved Issue#81"

3fb7402

This reverts commit 16031e4.

Resolved Issue PEC-CSS#81

019f9f2

Merge branch 'main' into Issue

e955eee

conflict resolved

9718f25

conflict resolved

c2d485e

F1 Score PEC-CSS#72

3512f9b

Resolved Conflict in matrix.cpp

5d0550e

Resolved PEC-CSS#72

93d1b7a

Formatted Code

0d73928

f1Score.md

c3fb7c9

Update f1Score.md

004c5c2

Update f1Score.md

8d19454

Implemented Distance Metric

2e4d110

Distance Metric

a55d7cb

test

4e01ffb

test

6601058

uttammittal02 requested changes Feb 14, 2023

View reviewed changes

uttammittal02 added pwoc medium labels Feb 14, 2023

Changes in DistanceMetric

cf7e2c6

uttammittal02 requested changes Feb 14, 2023

View reviewed changes

src/slowmokit/methods/metrics/distance_metric/distance_metric.cpp Outdated Show resolved Hide resolved

src/slowmokit/methods/metrics/distance_metric/distance_metric.cpp Outdated Show resolved Hide resolved

Changes Part 2, hopefully last

313e84e

uttammittal02 requested review from Ishwarendra and ken1000minus7 February 14, 2023 17:22

uttammittal02 requested changes Feb 15, 2023

View reviewed changes

Distance_metric.md

fbbeb70

uttammittal02 requested changes Feb 15, 2023

View reviewed changes

Modernbeast02 added 3 commits February 15, 2023 18:21

Hope Never Dies

56ead03

Merge branch 'main' of https://github.com/Modernbeast02/PWOC_slowmokit

77e2b07

Hope is Dead

deb0d05

uttammittal02 approved these changes Feb 15, 2023

View reviewed changes

Ishwarendra requested changes Feb 15, 2023

View reviewed changes

harshjohar reviewed Feb 15, 2023

View reviewed changes

ken1000minus7 reviewed Feb 15, 2023

View reviewed changes

harshjohar requested changes Feb 17, 2023

View reviewed changes

Modernbeast02 added 2 commits February 19, 2023 00:42

Resolved Conflicts

87d1367

Formatted

5c3a18e

	DistanceMetric<T>::DistanceMetric(std::vector<T> &x, std::vector<T> &y)
	DistanceMetric<T>::DistanceMetric(const std::vector<T> &x, const std::vector<T> &y)

	* @returns minkowski distance between the two vectors
	* @returns minkowski distance between the two vectors
	* @throws ...

Conversation

Modernbeast02 commented Feb 14, 2023

Uh oh!

uttammittal02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uttammittal02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

uttammittal02 left a comment

Choose a reason for hiding this comment

Uh oh!

uttammittal02 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uttammittal02 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Ishwarendra commented Feb 15, 2023

Uh oh!

harshjohar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ken1000minus7 left a comment

Choose a reason for hiding this comment

Uh oh!

harshjohar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

harshjohar left a comment •

edited

Loading