Rename files that rely on case-sensitive paths#190
Merged
Pennycook merged 1 commit intoP3HPC:mainfrom Apr 30, 2025
Merged
Conversation
On Windows, test.s and test.S are the same file. Signed-off-by: John Pennycook <john.pennycook@intel.com>
laserkelvin
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, test.s and test.S are the same file.
Related issues
Proposed changes
test.stolowercase.s.test.Stouppercase.S.No other changes are required, because the tests associated with these files look at every file in the directory. As such, we don't need to explicitly update any paths inside the tests.