Conversation
📝 WalkthroughWalkthroughThis PR pins Docker service image versions across three docker-compose files: PostgreSQL upgraded from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/api/docker-compose.redis.yml (1)
19-19: Good improvement pinning fromlatestto an explicit version.The current latest Redis on Docker Hub is
8.6, soredis:8.4is already two minor versions behind. The PR description mentions choosing 8.4 "due to Redis licensing starting from 8.0," but starting with Redis 8.0, Redis follows a tri-licensing model — all 8.x versions share the same license, so 8.4 doesn't differ from 8.6 in that respect.Consider whether
redis:8.6(or at least documenting the reason for staying on 8.4) would be more appropriate. Also, for better reproducibility, pinning to a patch version (e.g.,redis:8.4.0) prevents silent updates within the minor series.
API PR Checklist
Task Link
Osmosys Developers must include the Pinestem task link in the PR.
REST-2233
Pre-requisites
.env.examplefile with the required values as applicable.PR Details
PR details have been updated as per the given format (see below)
feat: add admin login endpoint)Additional Information
ready for reviewshould be added if the PR is ready to be reviewed)Note: Reviewer should ensure that the checklist and description have been populated and followed correctly, and the PR should be merged only after resolving all conversations and verifying that CI checks pass.
Description:
Pin osmox-postgres docker image to postgres:18
Pin osmox-redis docker image to redis:8.4
Related changes:
For Postgres we had already made a shift in how we pick mountpoint in #482
So decided to continue using postgres 18 as base image
Redis has added an open source license for versions starting from 8.0 onwards
So picked version one below latest i.e. redis:8.4
Screenshots:
Test suite/unit testing output:
Tested the following
Successful:
Test all API endpoints - working
Try sending mailgun notification - working
Try sending 360dialog notification - working
Try sending smtp email with attachment - working
Try sending twilio voice call - used an existing entry for testing - working
Try sending twilio whatsapp business message - used an existing entry in "TRACSHA -STG" for testing - working
Try sending plivo sms message - used an existing entry in "OQSHA -STG" for testing - working
Test the "test mode" functionality - working
Check if messages are processed for recipients which are added in "whitelist" - working
Check archive functionality of scheduler script - notifications archived successfully
Known Issues:
Check deleting archive notifications functionality of scheduler script
Additional notes:
We should keep a quarterly/semi annual reminder of updating image versions
Fixes the following issues
Links to images on Docker Hub
Summary by CodeRabbit