Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR syncs organization-wide standard files from the OrrisTech/.github repository to ensure consistency across all repositories in the organization. The sync includes developer tooling configurations, CI/CD workflows, documentation templates, and coding guidelines.
Changes:
- Added organizational coding rules and best practices documentation (.claude/org-rules.md)
- Added standardized PR template with comprehensive checklists (.github/pull_request_template.md)
- Added centralized CI workflow that calls reusable workflows from the org repo (.github/workflows/ci.yml)
- Added git hooks configuration for pre-commit linting, typechecking, and testing (lefthook.yml)
- Added standardized VSCode editor settings for consistent development experience (.vscode/settings.json)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| .claude/org-rules.md | Comprehensive organizational coding standards covering testing, React best practices, UI/design standards, SEO requirements, and security guidelines |
| .github/pull_request_template.md | Standardized PR template with checklists for code quality, testing, security, documentation, UI/design, SEO, and blog content |
| .github/workflows/ci.yml | Thin CI workflow that delegates to reusable workflows in the org repo for linting, testing, building, security audits, and React Doctor |
| lefthook.yml | Pre-commit hooks configuration that runs linting, type checking, and related tests on staged files with support for pnpm, bun, and npm |
| .vscode/settings.json | VSCode workspace settings for editor configuration, ESLint, TypeScript, Tailwind CSS IntelliSense, and search exclusions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "editor.tabSize": 2, | ||
| "editor.insertSpaces": true, | ||
| "editor.formatOnSave": true, | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", |
There was a problem hiding this comment.
The VSCode settings specify Prettier as the default formatter, but Prettier is not installed as a dependency in this repository. This configuration will not work for developers unless they have Prettier installed globally. Consider either adding Prettier as a dev dependency to the root package.json, or updating the formatter settings to match the actual formatting tools used in this repository (ESLint, Biome, or none).
| - [ ] Inline comments for complex logic only | ||
|
|
||
| ### UI / Design (if applicable) | ||
| - [ ] Follows design system (shadcn/ui + Tailwind CSS v4) |
There was a problem hiding this comment.
The pull request template references "Tailwind CSS v4" but this repository currently uses Tailwind CSS v3.4.17 (as seen in apps/website/package.json:56). This creates confusion for developers following the checklist. Update the reference to "Tailwind CSS v3" or remove the version number to avoid misleading developers about which version to use.
| - [ ] Follows design system (shadcn/ui + Tailwind CSS v4) | |
| - [ ] Follows design system (shadcn/ui + Tailwind CSS) |
| - [ ] Lint passes (`pnpm lint` / `npm run lint`) | ||
| - [ ] TypeScript compiles (`pnpm typecheck` / `npm run typecheck`) | ||
| - [ ] Build succeeds (`pnpm build` / `npm run build`) |
There was a problem hiding this comment.
The checklist references "pnpm lint / npm run lint" and "pnpm typecheck / npm run typecheck" and "pnpm build / npm run build", but this repository uses Bun as its package manager (packageManager: "bun@1.1.42" in package.json). For consistency and accuracy, these should reference "bun run lint", "bun run typecheck", and "bun run build" instead, or provide all three options including bun.
| - [ ] Lint passes (`pnpm lint` / `npm run lint`) | |
| - [ ] TypeScript compiles (`pnpm typecheck` / `npm run typecheck`) | |
| - [ ] Build succeeds (`pnpm build` / `npm run build`) | |
| - [ ] Lint passes (`bun run lint` / `pnpm lint` / `npm run lint`) | |
| - [ ] TypeScript compiles (`bun run typecheck` / `pnpm typecheck` / `npm run typecheck`) | |
| - [ ] Build succeeds (`bun run build` / `pnpm build` / `npm run build`) |
|
|
||
| ### Component Library & Styling | ||
| - Use **shadcn/ui** components as the base component library. | ||
| - Use **Tailwind CSS v4** for all styling. No inline styles, no CSS modules, no |
There was a problem hiding this comment.
The org rules document specifies "Use Tailwind CSS v4 for all styling" but this repository currently uses Tailwind CSS v3.4.17 (as seen in apps/website/package.json:56). This discrepancy creates confusion about which version developers should follow. Update this to reference Tailwind CSS v3, or update the repository's Tailwind dependency to match the org standard of v4.
| - Use **Tailwind CSS v4** for all styling. No inline styles, no CSS modules, no | |
| - Use **Tailwind CSS v3** for all styling. No inline styles, no CSS modules, no |
iamzifei
force-pushed
the
repo-sync/github/default
branch
from
3c96b92 to
0458f42
Compare
iamzifei
force-pushed
the
repo-sync/github/default
branch
from
0458f42 to
eb9ce6f
Compare
iamzifei
force-pushed
the
repo-sync/github/default
branch
from
eb9ce6f to
a6cfd1a
Compare
iamzifei
force-pushed
the
repo-sync/github/default
branch
from
a6cfd1a to
33cafc6
Compare
….github/pull_request_template.md'
…workflows/ci.yml'
iamzifei
force-pushed
the
repo-sync/github/default
branch
from
33cafc6 to
d49ec55
Compare
1 participant
synced local file(s) with OrrisTech/.github.
This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.
Changed files
.claude/org-rules.mdfrom remotesync/.claude/org-rules.md.github/pull_request_template.mdfrom remotesync/.github/pull_request_template.md.github/workflows/ci.ymlfrom remotesync/.github/workflows/ci.ymllefthook.ymlfrom remotesync/lefthook.yml.vscode/settings.jsonfrom remotesync/.vscode/settings.jsonThis PR was created automatically by the repo-file-sync-action workflow run #22209578770