-
Notifications
You must be signed in to change notification settings - Fork 96
152 deployment of Merkl Morpho pool booster #2677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2677 +/- ##
==========================================
- Coverage 38.28% 35.37% -2.91%
==========================================
Files 112 112
Lines 5331 5331
Branches 1412 1412
==========================================
- Hits 2041 1886 -155
- Misses 3289 3444 +155
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Contract Diff
sol2uml diff 0xAA8af8Db4B6a827B51786334d26349eb03569731 .,node_modules --apiKey
(node:3564) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "PoolBoostCentralRegistryProxy" contract with address 0xAA8af8Db4B6a827B51786334d26349eb03569731 on ethereum
to local files under folders ".,node_modules"
match @openzeppelin/contracts/utils/Address.sol
match contracts/governance/Governable.sol
match contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
match contracts/proxies/Proxies.sol
sol2uml diff 0x65d6977Da199143BfA467A100614e5cbf59711a6 .,node_modules --apiKey
(node:3592) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "PoolBoostCentralRegistry" contract with address 0x65d6977Da199143BfA467A100614e5cbf59711a6 on ethereum
to local files under folders ".,node_modules"
match contracts/governance/Governable.sol
match contracts/interfaces/poolBooster/IPoolBoostCentralRegistry.sol
match contracts/poolBooster/PoolBoostCentralRegistry.sol
sol2uml diff 0x0FC66355B681503eFeE7741BD848080d809FD6db .,node_modules --apiKey
(node:3688) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "PoolBoosterFactoryMerkl" contract with address 0x0FC66355B681503eFeE7741BD848080d809FD6db on ethereum
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match contracts/governance/Governable.sol
match contracts/interfaces/poolBooster/IMerklDistributor.sol
match contracts/interfaces/poolBooster/IPoolBoostCentralRegistry.sol
match contracts/interfaces/poolBooster/IPoolBooster.sol
match contracts/poolBooster/AbstractPoolBoosterFactory.sol
match contracts/poolBooster/PoolBoosterFactoryMerkl.sol
match contracts/poolBooster/PoolBoosterMerkl.sol
Maybe can you fixe the Linter?
Looks good to me 👍
|
Thanks linter fixed |
shahthepro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Contracts deployed
Sol2uml
Governance action
Governance proposal: 88571309263461999046223385877946752282612145620560563525414048647990244142989
Deploy checklist
Two reviewers complete the following checklist: