Skip to content

Conversation

@sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Oct 3, 2025

Contracts deployed

Contract Address
PoolBoostCentralRegistryProxy 0xAA8af8Db4B6a827B51786334d26349eb03569731
PoolBoostCentralRegistry 0x65d6977Da199143BfA467A100614e5cbf59711a6
PoolBoosterFactoryMerkl 0x0FC66355B681503eFeE7741BD848080d809FD6db

Sol2uml

sol2uml diff 0xAA8af8Db4B6a827B51786334d26349eb03569731  .,node_modules --apiKey [apiKey]
sol2uml diff 0x65d6977Da199143BfA467A100614e5cbf59711a6  .,node_modules --apiKey [apiKey]
sol2uml diff 0x0FC66355B681503eFeE7741BD848080d809FD6db  .,node_modules --apiKey [apiKey]

Governance action

Governance proposal: 88571309263461999046223385877946752282612145620560563525414048647990244142989

Gas price (gwei): Regular=0.275997704 Premium=0.413996556
INFO: Next step: go to Gnosis Safe Web -> New Transaction -> 👷 Contract Interaction
INFO:   - enable "Custom Data" toggle
INFO:   - set "Enter address or ENS name" to: '0x1D3Fbd4d129Ddd2372EA85c5Fa00b2682081c9EC'
INFO:   - set "ETH value" to: 0
INFO:   - set "Data (Hex encoded)" to:
INFO: 0xda95691a00000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000012000000000000000000000000000000000000000000000000000000000000001a000000000000000000000000000000000000000000000000000000000000002200000000000000000000000000000000000000000000000000000000000000001000000000000000000000000aa8af8db4b6a827b51786334d26349eb0356973100000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000017617070726f7665466163746f72792861646472657373290000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000fc66355b681503efee7741bd848080d809fd6db000000000000000000000000000000000000000000000000000000000000001f417070726f766520506f6f6c426f6f73746572466163746f72794d65726b6c00
INFO:   - click on 'Add Transaction

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.37%. Comparing base (c267e54) to head (00891fd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2677      +/-   ##
==========================================
- Coverage   38.28%   35.37%   -2.91%     
==========================================
  Files         112      112              
  Lines        5331     5331              
  Branches     1412     1412              
==========================================
- Hits         2041     1886     -155     
- Misses       3289     3444     +155     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

clement-ux
clement-ux previously approved these changes Oct 3, 2025
Copy link
Collaborator

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

Contract Diff

sol2uml diff 0xAA8af8Db4B6a827B51786334d26349eb03569731  .,node_modules --apiKey
(node:3564) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "PoolBoostCentralRegistryProxy" contract with address 0xAA8af8Db4B6a827B51786334d26349eb03569731 on ethereum
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/utils/Address.sol
match   contracts/governance/Governable.sol
match   contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
match   contracts/proxies/Proxies.sol
sol2uml diff 0x65d6977Da199143BfA467A100614e5cbf59711a6  .,node_modules --apiKey
(node:3592) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "PoolBoostCentralRegistry" contract with address 0x65d6977Da199143BfA467A100614e5cbf59711a6 on ethereum
to local files under folders ".,node_modules"

match   contracts/governance/Governable.sol
match   contracts/interfaces/poolBooster/IPoolBoostCentralRegistry.sol
match   contracts/poolBooster/PoolBoostCentralRegistry.sol
sol2uml diff 0x0FC66355B681503eFeE7741BD848080d809FD6db  .,node_modules --apiKey
(node:3688) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "PoolBoosterFactoryMerkl" contract with address 0x0FC66355B681503eFeE7741BD848080d809FD6db on ethereum
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/poolBooster/IMerklDistributor.sol
match   contracts/interfaces/poolBooster/IPoolBoostCentralRegistry.sol
match   contracts/interfaces/poolBooster/IPoolBooster.sol
match   contracts/poolBooster/AbstractPoolBoosterFactory.sol
match   contracts/poolBooster/PoolBoosterFactoryMerkl.sol
match   contracts/poolBooster/PoolBoosterMerkl.sol

Maybe can you fixe the Linter?

Looks good to me 👍

@sparrowDom
Copy link
Member Author

Thanks linter fixed

Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

Base automatically changed from sparrowDom/boosterSetupMainnet to master October 6, 2025 09:04
@sparrowDom sparrowDom dismissed clement-ux’s stale review October 6, 2025 09:04

The base branch was changed.

@sparrowDom sparrowDom changed the title add deployment files 152 deployment of Merkl Morpho pool booster Oct 6, 2025
@sparrowDom sparrowDom merged commit ca702bf into master Oct 6, 2025
10 of 15 checks passed
@sparrowDom sparrowDom deleted the sparrowDom/deploy_152 branch October 6, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants