refactor(protocol-designer): figure out why getTiprackVolume() is failing #20400
+9
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding instrumentation to figure out why failures like this are happening:
https://opentrons-76.sentry.io/issues/6841220504?project=4509363266387968
We're calling
getTiprackVolume()with a tip rack definition ofundefined. That could happen because:tipRackDefUri(which comes from the form) is undefined.pipetteEntity.tiprackLabwareDefarray.pipetteEntity.tiprackLabwareDefis empty for some reason (the original code tried to usepipetteEntity.tiprackLabwareDef[0]as a fallback, which I don't think helps anything).This PR simplifies the code and adds more information to the
console.assert()to help us figure out what's going on.Test Plan and Hands on Testing
Smoke-tested locally by editing a Transfer step.
Run CI tests.
Risk assessment
Low.