Skip to content

Conversation

@ddcc4
Copy link
Collaborator

@ddcc4 ddcc4 commented Dec 16, 2025

Overview

Adding instrumentation to figure out why failures like this are happening:
https://opentrons-76.sentry.io/issues/6841220504?project=4509363266387968

We're calling getTiprackVolume() with a tip rack definition of undefined. That could happen because:

  • The tipRackDefUri (which comes from the form) is undefined.
  • Or it is defined, but we can't find it in the pipetteEntity.tiprackLabwareDef array.
  • Or pipetteEntity.tiprackLabwareDef is empty for some reason (the original code tried to use pipetteEntity.tiprackLabwareDef[0] as a fallback, which I don't think helps anything).

This PR simplifies the code and adds more information to the console.assert() to help us figure out what's going on.

Test Plan and Hands on Testing

Smoke-tested locally by editing a Transfer step.
Run CI tests.

Risk assessment

Low.

@ddcc4 ddcc4 requested review from jerader and ncdiehl11 December 16, 2025 23:16
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.09%. Comparing base (90aabcd) to head (54d926d).
⚠️ Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #20400   +/-   ##
=======================================
  Coverage   56.09%   56.09%           
=======================================
  Files        3678     3678           
  Lines      309736   309732    -4     
  Branches    45830    45828    -2     
=======================================
  Hits       173741   173741           
+ Misses     135752   135748    -4     
  Partials      243      243           
Flag Coverage Δ
protocol-designer 19.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol-designer/src/pipettes/pipetteData.ts 81.81% <100.00%> (+6.81%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddcc4 ddcc4 merged commit ddf9ef4 into edge Dec 24, 2025
16 checks passed
@ddcc4 ddcc4 deleted the gettiprackvolume branch December 24, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants