feat: 优化决任务逻辑，使得可维修的船应修尽修 #309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
主要功能是允许中断决战执行修理吗？还是别的什么？ 目前决战调度似乎有 bug，一次只能浴场修一艘，如果你这个 PR 的主要目的是允许中断决战执行额外的修理任务，那么应该有更好的实现 |
Author
主要两个，一个是满足维修条件时中断执行，先泡澡。另外一个是注册时不耗桶，已经在维修的船利用计时器定时假定修好，再交给战前检查重置状态。额外的一个是把repair_strategy引入决任务。 |
Contributor
|
逻辑上没有问题，你可以自己再测试五轮决战左右，运行没有出现问题我就通过本 PR
东南大学-毛周祥
***@***.***
|
task_runner.py: · register()中添加quick_repair_mode参数以控制注册时是否快修 · RepairTask()中添加scan()方法用于手动扫描可维修的船; 添加managed_repaired_ships标记位标记runner管理的维修 · DecisiveFight()中引入repair_strategy; 重写repair()以适应盲计时和抛出退出决战的钩子 · 大幅修改DecisiveFightTask()的逻辑以适应中断决战插入维修任务 · TaskRunner()中添加所有任务完成后应修尽修的逻辑 decisive_battle.py: · 将repair_strategy引入决战逻辑 · 修改need_repair()以抛出钩子 common.py: · WorkShop的_time_to_seconds()中解决了读取维修时间时将":"识别为"."的问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task_runner.py:
· register()中添加quick_repair_mode参数以控制注册时是否快修
· RepairTask()中添加scan()方法用于手动扫描可维修的船; 添加managed_repaired_ships标记位标记runner管理的维修 · DecisiveFight()中引入repair_strategy; 重写repair()以适应盲计时和抛出退出决战的钩子 · 大幅修改DecisiveFightTask()的逻辑以适应中断决战插入维修任务
· TaskRunner()中添加所有任务完成后应修尽修的逻辑
decisive_battle.py:
· 将repair_strategy引入决战逻辑
· 修改need_repair()以抛出钩子
common.py:
· WorkShop的_time_to_seconds()中解决了读取维修时间时将":"识别为"."的问题