feat: .NET 10 #251

hhvrc · 2025-11-06T20:58:29Z

To be merged after .NET 10 release date, November 11th 2025
closes #185

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Common/OpenShockMiddlewareHelper.cs

hhvrc · 2025-11-11T19:39:27Z

Currently waiting on Npgsql.EntityFrameworkCore.PostgreSQL to release the .NET 10 version
This will be done in npgsql/npgsql#6311

This reverts commit 3b10388.

This reverts commit 89dadb9.

* fix: dotnet 10 openapi * fix: use same Title * fix: use better operationId transform * fix: break operationId "DevicePair" into separate endpoints

Copilot

Pull request overview

This PR upgrades the project from .NET 9 to .NET 10, scheduled for release after November 11th, 2025. The upgrade includes updating the SDK, runtime, packages, and migrating from Swashbuckle/Swagger to the native Microsoft.AspNetCore.OpenApi implementation.

Updated .NET SDK and runtime to version 10.0
Migrated from Swashbuckle to Microsoft.AspNetCore.OpenApi with new document generation and Scalar API viewer integration
Updated NuGet packages to their .NET 10 compatible versions
Applied code refactorings leveraging C# 13 features (field keyword) and API improvements

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
global.json	Updated SDK version to 10.0.0 and added Microsoft.Testing.Platform test runner configuration
docker/*.Dockerfile	Updated base images from dotnet 9.0-alpine to 10.0-alpine
Directory.Packages.props	Updated all Microsoft packages and dependencies to version 10.0.0, removed Swashbuckle package
Directory.Build.props	Updated target framework to net10.0 and added OpenAPI interceptors namespace
LiveControlGateway/Program.cs, Cron/Program.cs, API/Program.cs	Replaced AddSwaggerExt with AddOpenApiExt and updated namespace imports
LiveControlGateway/Controllers/HubControllerBase.cs	Refactored property to use C# 13 field keyword for cleaner auto-property backing field access
Common/Utils/TrustedProxiesFetcher.cs	Simplified lambda expression removing unnecessary parameter specification
Common/Utils/ConfigureSwaggerOptions.cs	Removed - functionality migrated to new OpenAPI implementation
Common/Swagger/*	Removed Swashbuckle-specific files including SwaggerGenExtensions.cs and AttributeFilter.cs
Common/OpenAPI/OpenApiExtensions.cs	New OpenAPI document configuration with output caching and custom operation ID generation
Common/OpenAPI/DocumentDefaults.cs	New document transformer defining API info, servers, and security schemes
Common/OpenShockServiceHelper.cs	Updated API versioning configuration for compatibility with new OpenAPI generation
Common/OpenShockMiddlewareHelper.cs	Replaced UseSwagger with MapOpenApi, updated Scalar viewer configuration, changed KnownNetworks to KnownIPNetworks
Common/Services/Session/SessionService.cs	Changed ToArrayAsync to ToListAsync and updated Length to Count for consistency
Common/Hubs/UserHub.cs	Changed ToArrayAsync to ToListAsync for consistency with EF Core best practices
Common/DataAnnotations/*.cs	Removed IParameterAttribute interface implementations and OpenAPI-specific Apply methods
Common/DataAnnotations/OpenApiSchemas.cs	Removed - schemas now handled through native OpenAPI mechanisms
Common/DataAnnotations/Interfaces/*	Removed custom attribute interfaces as they're replaced by native OpenAPI extensibility
Common/Common.csproj	Added Microsoft.AspNetCore.OpenApi package, removed Swashbuckle.AspNetCore.SwaggerGen
API/Services/LCGNodeProvisioner/LCGNodeProvisioner.cs	Changed ToArrayAsync to ToListAsync and Length to Count
API/Controller/Sessions/ListSessions.cs	Refactored to return IAsyncEnumerable directly with Select instead of manual yield
API/Controller/OAuth/_ApiController.cs	Added EndpointGroupName attribute for API grouping, consolidated ApiVersion attribute
API/Controller/OAuth/*.cs	Removed ApiExplorerSettings(IgnoreApi = true) to include OAuth endpoints in OpenAPI docs
API/Controller/Device/Pair.cs	Split endpoint into two methods (Pair and PairDeprecated) with separate EndpointName attributes and shared PairInternal helper
API/Controller/Admin/_ApiController.cs	Added EndpointGroupName attribute for admin API grouping
API/Controller/Admin/GetOnlineDevices.cs	Changed ToArrayAsync to ToListAsync
API.IntegrationTests/Tests/LcgAssignmentTests.cs	Changed ToArrayAsync to ToListAsync in test cleanup
.github/workflows/*.yml	Updated DOTNET_VERSION to 10.x.x and 10.0.x, modified test command syntax

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-25T22:57:16Z

Common/OpenAPI/OpenApiExtensions.cs

+        using (var tempProvider = builder.Services.BuildServiceProvider())
+        {
+            var apiVersionProvider = tempProvider.GetRequiredService<IApiVersionDescriptionProvider>();
+
+            // Configure OpenAPI for each API version
+            foreach (var description in apiVersionProvider.ApiVersionDescriptions)
+            {
+                builder.Services.AddOpenApi(description.GroupName, options =>
+                {
+                    options.OpenApiVersion = OpenApiSpecVersion.OpenApi3_1;
+                    options.AddDocumentTransformer(DocumentDefaults.GetDocumentTransformer(
+                        version: description.ApiVersion.ToString()));
+                    options.CreateSchemaReferenceId = (type) =>
+                    {
+                        var defaultName = type.Type.Name;
+                        var cleanName = defaultName
+                            .Replace("[]", "Array")
+                            .Replace("`1", "Of")
+                            .Replace("`2", "OfTwo");
+                        return cleanName;
+                    };
+                    options.AddOperationTransformer((operation, context, cancellationToken) =>
+                    {
+                        var actionDescriptor = context.Description.ActionDescriptor;
+
+                        // Use endpoint name if available
+                        var endpointName = actionDescriptor.EndpointMetadata
+                            .OfType<EndpointNameMetadata>()
+                            .FirstOrDefault()?.EndpointName;
+
+                        if (!string.IsNullOrEmpty(endpointName))
+                        {
+                            operation.OperationId = endpointName;
+                            return Task.CompletedTask;
+                        }
+
+                        // For controllers
+                        var controller = actionDescriptor.RouteValues.TryGetValue("controller", out var ctrl) ? ctrl : null;
+                        var action = actionDescriptor.RouteValues.TryGetValue("action", out var act) ? act : null;
+
+                        if (!string.IsNullOrEmpty(controller) && !string.IsNullOrEmpty(action))
+                        {
+                            operation.OperationId = $"{controller}{action}";
+                        }
+
+                        return Task.CompletedTask;
+                    });
+                });
+            }
+        }
+


Building a temporary service provider within the service configuration can lead to issues. This pattern captures services at configuration time and may not include all registered services or properly dispose of them. Consider using IConfigureOptions pattern or deferring this logic to application startup where the service provider is fully built.

Suggested change

using (var tempProvider = builder.Services.BuildServiceProvider())

{

var apiVersionProvider = tempProvider.GetRequiredService<IApiVersionDescriptionProvider>();

// Configure OpenAPI for each API version

foreach (var description in apiVersionProvider.ApiVersionDescriptions)

{

builder.Services.AddOpenApi(description.GroupName, options =>

{

options.OpenApiVersion = OpenApiSpecVersion.OpenApi3_1;

options.AddDocumentTransformer(DocumentDefaults.GetDocumentTransformer(

version: description.ApiVersion.ToString()));

options.CreateSchemaReferenceId = (type) =>

{

var defaultName = type.Type.Name;

var cleanName = defaultName

.Replace("[]", "Array")

.Replace("`1", "Of")

.Replace("`2", "OfTwo");

return cleanName;

};

options.AddOperationTransformer((operation, context, cancellationToken) =>

{

var actionDescriptor = context.Description.ActionDescriptor;

// Use endpoint name if available

var endpointName = actionDescriptor.EndpointMetadata

.OfType<EndpointNameMetadata>()

.FirstOrDefault()?.EndpointName;

if (!string.IsNullOrEmpty(endpointName))

{

operation.OperationId = endpointName;

return Task.CompletedTask;

}

// For controllers

var controller = actionDescriptor.RouteValues.TryGetValue("controller", out var ctrl) ? ctrl : null;

var action = actionDescriptor.RouteValues.TryGetValue("action", out var act) ? act : null;

if (!string.IsNullOrEmpty(controller) && !string.IsNullOrEmpty(action))

{

operation.OperationId = $"{controller}{action}";

}

return Task.CompletedTask;

});

});

}

}

// NOTE:

// The previous implementation built a temporary service provider here to resolve

// IApiVersionDescriptionProvider and register an OpenAPI document per API version.

// Building a temporary provider during service registration is an anti-pattern and

// was flagged by static analysis. Per-version OpenAPI document registration should

// be performed in a component that receives IApiVersionDescriptionProvider via DI

// (for example, using IConfigureOptions in another part of the application) rather

// than by calling BuildServiceProvider() on builder.Services.

API/Controller/Device/Pair.cs

Copilot · 2025-12-25T22:57:16Z

.github/workflows/ci-build.yml

        run: |
          set -euo pipefail
-          dotnet test -c Release ${{ matrix.project }}
+          dotnet test -c Release --project ${{ matrix.project }}


The --project flag is incorrect syntax for dotnet test. The correct syntax is to pass the project path directly without a flag, as it was before. Change back to: dotnet test -c Release ${{ matrix.project }}

Suggested change

dotnet test -c Release --project ${{ matrix.project }}

dotnet test -c Release ${{ matrix.project }}

Copilot · 2025-12-25T22:57:17Z

Common/OpenAPI/OpenApiExtensions.cs

+        var assembly = typeof(TProgram).Assembly;
+
+        string assemblyName = assembly
+                                .GetName()
+                                .Name ?? throw new NullReferenceException("Assembly name");
+


This assignment to assemblyName is useless, since its value is never read.

Suggested change

var assembly = typeof(TProgram).Assembly;

string assemblyName = assembly

.GetName()

.Name ?? throw new NullReferenceException("Assembly name");

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

hhvrc added 14 commits September 24, 2025 12:08

Create initial draft for .NET 10 changes

f18ee5c

Merge branch 'develop' into feature/dotnet-10

3143802

Update Directory.Packages.props

b283abf

Use field keyword

510d44e

Merge branch 'develop' into feature/dotnet-10

a6c9ec1

Update Directory.Packages.props

1320cbb

Fix some errors

2735fa6

Merge branch 'develop' into feature/dotnet-10

67c7a4d

Update Directory.Packages.props

590ea33

Update global.json

a9b75ad

Merge branch 'develop' into feature/dotnet-10

70124a0

Revert some changes

6775c2d

Improve SessionService SessionLister

cc11289

Update global.json

ba965b6

hhvrc requested a review from LucHeart November 6, 2025 20:58

hhvrc self-assigned this Nov 6, 2025

hhvrc added enhancement New feature or request .NET Pull requests that update .NET code labels Nov 6, 2025

Revert some changes

d1adb30

chatgpt-codex-connector bot reviewed Nov 6, 2025

View reviewed changes

Common/OpenShockMiddlewareHelper.cs Show resolved Hide resolved

hhvrc added 5 commits November 6, 2025 22:21

Merge branch 'develop' into feature/dotnet-10

e0307a5

Update ListSessions.cs

c18cd36

Update ListSessions.cs

63c6565

Merge branch 'develop' into feature/dotnet-10

16ff23c

Update Directory.Packages.props

296df41

hhvrc added 4 commits November 11, 2025 20:40

Update Directory.Packages.props

3b10388

Update workflows

a550140

Update docker files

2395048

Revert "Update Directory.Packages.props"

63df5fd

This reverts commit 3b10388.

hhvrc added 3 commits November 11, 2025 21:01

OpenAPI broke

35b530d

This is gonna be alot of work

b669fd2

Oops

ae70c50

hhvrc marked this pull request as draft November 11, 2025 21:31

hhvrc and others added 12 commits November 12, 2025 11:16

Update Directory.Packages.props

1d1ee8c

More changes

89dadb9

Revert "More changes"

22647c3

This reverts commit 89dadb9.

Update Directory.Packages.props

e90f7ef

Update global.json

7bb8598

Update ci-build.yml

9981506

Merge branch 'develop' into feature/dotnet-10

126f33d

Update Serilog.AspNetCore to 10.0.0

ac1dd0d

Merge branch 'develop' into feature/dotnet-10

8fb7a5c

Additional fixes

ac363cf

fix: dotnet 10 openapi (#261)

356f514

Fix/dotnet 10 openapi 2 (#264)

250b27a

* fix: dotnet 10 openapi * fix: use same Title * fix: use better operationId transform * fix: break operationId "DevicePair" into separate endpoints

LucHeart requested a review from Copilot December 25, 2025 22:52

Copilot started reviewing on behalf of LucHeart December 25, 2025 22:53 View session

Copilot AI reviewed Dec 25, 2025

View reviewed changes

LucHeart and others added 6 commits December 26, 2025 01:13

Update API/Controller/Device/Pair.cs

56a876d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Exclude legacy endpoint from generated OpenAPI document

35cb74d

More comprehensive SchemaReferenceId generator

196ac0d

Fix doc exclude

6684a17

Update OpenApiExtensions.cs

f0edbb7

Update OpenApiExtensions.cs

2bdd976

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: .NET 10 #251

feat: .NET 10 #251

hhvrc commented Nov 6, 2025 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

hhvrc commented Nov 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	dotnet test -c Release --project ${{ matrix.project }}
	dotnet test -c Release ${{ matrix.project }}

feat: .NET 10 #251

Are you sure you want to change the base?

feat: .NET 10 #251

Conversation

hhvrc commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

hhvrc commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hhvrc commented Nov 6, 2025 •

edited

Loading

hhvrc commented Nov 11, 2025 •

edited

Loading