Open
Conversation
janrysavy
added
the
comments translation
janrysavy
reviewed
Dec 26, 2023
| if (msgBoxThread != NULL) | ||
| { | ||
| WaitForSingleObject(msgBoxThread, INFINITE); // pokud se da TRACE_C do DllMain do DLL_THREAD_ATTACH, dojde k deadlocku - silne nepravdepodobne, neresime | ||
| WaitForSingleObject(msgBoxThread, INFINITE); // if TRACE_C is in DllMain to DLL_THREAD_DETACH, deadlock will occur - very unlikely, not solved |
| else // ostatni thready s TRACE_C zablokujeme, az se zavre msgbox otevreny pro | ||
| { // prvni TRACE_C, tak to tam i spadne, at v tom neni bordel | ||
| else // we will block another threads with TRACE_C, once the msgbox, opened | ||
| // for the first TRACE_C, is closed, it will be passed there, so that there is no mess |
Contributor
There was a problem hiding this comment.
it will be passed there, so that there is no mess
->
so it will crash there, to avoid a mess
| { | ||
| while (1) | ||
| Sleep(1000); // blokace vede na deadlock napr. kdyz je (a nema byt) TRACE_C v DLL_THREAD_DETACH | ||
| Sleep(1000); // blocking leads to deadlock, e.g. when TRACE_C is in DLL_THREAD_DETACH (but it should not) |
Contributor
There was a problem hiding this comment.
(but it should not) -> (and should not be)
| // SPDX-License-Identifier: GPL-2.0-or-later | ||
|
|
||
| // CommentsTranslationProject: TRANSLATED | ||
| // |
| // CALL-STACK is disabled by defining CALLSTK_DISABLE macro | ||
|
|
||
| // CAUTION: TRACE_C can't be used in DllMain of libraries, nor in any code called from DllMain, | ||
| // otherwise deadlock occurs, see implementation of C__Trace::SendMessageToServer |
Contributor
There was a problem hiding this comment.
align otherwise with TRACE_C (column)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.