Delete by thread #8
Conversation
chat_api/threads/thread_views.py
Outdated
| return service.get_thread_by_id(thread_id) | ||
|
|
||
|
|
||
| @thread_router.delete("/threads/{thread_id}") |
There was a problem hiding this comment.
/threads should be at the router level
There was a problem hiding this comment.
Need to follow the MVC model
chat_api/threads/thread_views.py
Outdated
|
|
||
|
|
||
| @thread_router.delete("/threads/{thread_id}") | ||
| def delete_thread(thread_id: UUID, db: Session = Depends(get_db)): |
There was a problem hiding this comment.
Delete api should have no response and it should HTTP status 204
chat_api/threads/thread_service.py
Outdated
|
|
||
| return messages | ||
|
|
||
| def delete_thread_by_id(self, thread_id: UUID) -> dict: |
There was a problem hiding this comment.
No Response from here
| ) | ||
|
|
||
| def soft_delete_thread(self, thread_id: UUID) -> bool: | ||
| thread = self.db.query(Thread).filter( |
There was a problem hiding this comment.
we do not have to check if its already deleted for this case.
Just set it to true but take care of thread id not found issue
There was a problem hiding this comment.
NO change here. Still same logic
There was a problem hiding this comment.
NO change here. Still same logic
tenzinsamten
left a comment
tenzinsamten
left a comment
There was a problem hiding this comment.
check thread delete in repository
| ) | ||
|
|
||
| def soft_delete_thread(self, thread_id: UUID) -> bool: | ||
| thread = self.db.query(Thread).filter( |
There was a problem hiding this comment.
NO change here. Still same logic
| ) | ||
|
|
||
| def soft_delete_thread(self, thread_id: UUID) -> bool: | ||
| thread = self.db.query(Thread).filter( |
There was a problem hiding this comment.
NO change here. Still same logic
| messages = [] | ||
| sorted_chats = sorted(chats, key=lambda x: x.created_at) | ||
| async def delete_thread_by_id(thread_id: UUID) -> None: |
There was a problem hiding this comment.
This is not the optimzation that we talked about because here also you are calling the database 2 times. you just moved the logic from repository to service.
There was a problem hiding this comment.
It should be one Single database operation
No description provided.