Skip to content

Include s/w binning options in CalStepDialog and ManualGuide #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwdev01 merged 1 commit into from
Jan 4, 2026
Merged

Include s/w binning options in CalStepDialog and ManualGuide #1423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/calstep_dialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ CalstepDialog::CalstepDialog(wxWindow *parent, int focalLength, double pixelSize

// binning
wxArrayString opts;
bool includeSwBinning = false; // TODO: SW binning UI
bool includeSwBinning = true; // Include s/w options for "what-if" use cases
GuideCamera::GetBinningOpts(&opts, pCamera ? pCamera->MaxHwBinning : 1, includeSwBinning);
m_binningChoice = new wxChoice(this, wxID_ANY, wxDefaultPosition, wxDefaultSize, opts);
m_binningChoice->Enable(!pFrame->pGuider || !pFrame->pGuider->IsCalibratingOrGuiding());
Expand Down
2 changes: 1 addition & 1 deletion src/manualcal_dialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ ManualCalDialog::ManualCalDialog(const Calibration& cal)

wxStaticText *pLabel = new wxStaticText(this, wxID_ANY, _("Camera binning:"));
wxArrayString opts;
bool includeSwBinning = false; // TODO: SW binning UI
bool includeSwBinning = true; // Dialog is for expert use only so include s/w options
pCamera->GetBinningOpts(&opts, includeSwBinning);
m_binning = new wxChoice(this, wxID_ANY, wxDefaultPosition, wxDefaultSize, opts);
SetIntChoice(m_binning, cal.binning);
Expand Down