fix: Update SQL mock expectations for recent schema changes#186
fix: Update SQL mock expectations for recent schema changes#186mushrafmim merged 1 commit intoOpenNSW:mainfrom
Conversation
Summary of ChangesHello @ginaxu1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses necessary updates to SQL mock expectations within the test suite. These changes ensure that the tests accurately reflect recent modifications to the database schema for both Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates SQL mock expectations in tests to align with recent database schema changes. The changes correctly adjust the number of arguments for INSERT and UPDATE statements in consignment_service_test.go and workflow_node_service_test.go.
I've found one issue in a newly added mock expectation in consignment_service_test.go where the number of arguments in WithArgs does not match the query placeholders. Please see my detailed comment.
Testing