Add Workflow Node Outcome in TaskManager

[ginaxu1]

Summary

Add outcome field through the TaskManager plugin execution pipeline. This enables task plugins to produce and communicate completion sub-states (like "APPROVED" or "REJECTED") back to the workflow manager, which is a requirement for evaluating conditional unlock rules (per those introduced in #174).

Type of Change

• New feature (non-breaking change which adds functionality

Changes Made

• Add an optional Outcome field (*string) to plugin.ExecutionResponse
• Update execute() method in manager.go to extract the Outcome from the ExecutionResponse and pass it to the notifyWorkflowManager() function
• Update the signature of notifyWorkflowManager() in manager.go to accept the outcome parameter and updated WorkflowManagerNotification in notification.go to utilize this Outcome field

Testing

go test ./internal/task/manager/... to verify all TaskManager tests pass with the updated method signatures

[gemini-code-assist]

Summary of Changes

Hello @ginaxu1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the TaskManager by adding an outcome field to the plugin execution pipeline. This allows task plugins to provide more detailed completion statuses (e.g., 'APPROVED', 'REJECTED') to the workflow manager, which is essential for evaluating conditional unlock rules. The changes include updating the ExecutionResponse struct, modifying the execute() method to extract the outcome, and updating the notifyWorkflowManager() function to pass the outcome to the workflow manager.

Highlights

• Outcome Field: Introduced an Outcome field to the plugin.ExecutionResponse struct, allowing task plugins to communicate completion sub-states to the workflow manager.
• Notification Update: Modified the notifyWorkflowManager function to accept and utilize the Outcome field when notifying the workflow manager.
• Conditional Unlock Rules: This change supports the evaluation of conditional unlock rules by providing more granular task completion statuses.

Changelog

• backend/internal/task/manager/manager.go
  • Modified to include the outcome in the notification to the workflow manager.
• backend/internal/task/manager/manager_test.go
  • Updated tests to accommodate the new outcome parameter in notifyWorkflowManager.
• backend/internal/task/plugin/plugin.go
  • Added the Outcome field to the ExecutionResponse struct.

Activity

• The PR introduces a new Outcome field to the plugin.ExecutionResponse struct.
• The execute() method in manager.go was updated to extract the Outcome from the ExecutionResponse.
• The signature of notifyWorkflowManager() in manager.go was updated to accept the outcome parameter.
• TaskManager tests were updated to verify the updated method signatures.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds an outcome field to the task execution pipeline, allowing task plugins to communicate completion sub-states. The changes are well-implemented, introducing the Outcome field in plugin.ExecutionResponse and propagating it through the TaskManager to the WorkflowManagerNotification. I have a couple of suggestions to improve logging consistency and test coverage for this new feature.